Implement frame node for MDL via scene data#2823
Merged
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom Mar 13, 2026
Merged
Implement frame node for MDL via scene data#2823jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Member
|
Thanks for putting together this PR, @pablode, and I'll defer to @jreichel-nvidia on reviewing this specific implementation. |
Contributor
|
LGTM, except that I think 0.0 would be better default. |
Member
|
@jreichel-nvidia That might be a broader change than the MDL implementation in this PR, since the |
jstone-lucasfilm
approved these changes
Mar 13, 2026
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
I trust @jreichel-nvidia's approval on this, and his note about the default value is a broader change than this PR is intended to address, so I'd say this looks ready to merge.
jstone-lucasfilm
merged commit 033004e
into
AcademySoftwareFoundation:main
36 checks passed
Contributor
|
Ok, fine. I didn't realize that 1.0 is the explicit default in the spec, just thought of zero as a general default value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in Slack.