Unify environment light texture handling in MaterialXRenderMsl#2870
Open
warrenm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
Unify environment light texture handling in MaterialXRenderMsl#2870warrenm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
warrenm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
warrenm
force-pushed
the
indirect-lighting-msl-2851
branch
from
152a546 to
e371b74
Compare
warrenm
force-pushed
the
indirect-lighting-msl-2851
branch
from
e371b74 to
0293504
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to address #2851.
The core issue is that the Metal rendering code wasn't honoring the indirect lighting property of the light handler. However, changing the logic to match that of the implementation in
bindLighting()in GlslProgram isn't quite enough. There were actually two independent paths for binding IBL textures in the Metal implementation, one inbindLighting()and one in the lower-levelbindTextures(). This change unifies those two paths into a single path relying on the explicit bound texture mechanism currently used for shadow mapping.This change seems fairly natural to me, but I would appreciate any other Metal renderer implementation experts weighing in.
Tested in MaterialXView on macOS Tahoe 26.4:
fix.mov