Connect gltf pbr attenuation distance#2872
Open
bhouston wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
Connect gltf pbr attenuation distance#2872bhouston wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
bhouston wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
bhouston
force-pushed
the
connect-gltf-pbr-attenuation-distance
branch
from
af5eb7d to
25f0ac0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another fix resulting from my use of the MaterialX Fidelity tool here: https://materialx-fidelity.ben3d.ca
I was finding that materials with attention colours where not rendering with any tint in the MaterialXView, like this material:
https://materialx-fidelity.ben3d.ca/api/asset/gltf_pbr/default_subset_transmission.mtlx.zip
Was rendering like this:
I fixed it to render like this via this PR:
The fix seems to be just modifying this one mtlx file since its attention sub-graph was disconnected.