fix(ImageSpec): ImageSpec::get_string_attribute didn't correctly translate to string#5161
Merged
lgritz merged 1 commit intoAcademySoftwareFoundation:mainfrom Apr 23, 2026
Merged
Conversation
…ring This method was advertized as being able to convert any type of the attribute into a string, but actually, it would only *search* for attributes that were entered as strings, so there was no conversion happening. Beef up testing of paramlist and imgespec to cover the holes that let this mistake happen. Fixed a couple typos in imageio.h comments as well. Signed-off-by: Larry Gritz <lg@larrygritz.com>
jessey-git
approved these changes
Apr 23, 2026
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 23, 2026
…slate to string (AcademySoftwareFoundation#5161) This method is advertised as being able to convert any type of the attribute into a string, but actually, it would only *search* for attributes that were entered as strings, so there was no conversion happening. Beef up testing of paramlist and imagespec to cover the holes that let this mistake happen. Fixed a couple typos in imageio.h comments as well. Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is advertised as being able to convert any type of the attribute into a string, but actually, it would only search for attributes that were entered as strings, so there was no conversion happening.
Beef up testing of paramlist and imagespec to cover the holes that let this mistake happen.
Fixed a couple typos in imageio.h comments as well.