Add footnote about colors being in-gamut (i.e. components in [0,1])#208
Add footnote about colors being in-gamut (i.e. components in [0,1])#208portsmouth wants to merge 32 commits intoAcademySoftwareFoundation:dev_1.1.1from
Conversation
|
@anderslanglands and @KelSolaar Would appreciate your thoughts on whether this change makes sense. |
|
It might also be: "... all RGB colours are in-gamut of the working space, i.e., have components in the
|
OK, so in your view "in-gamut" (of the working color space of the shader) simply means that the color components are non-negative?
Can you clarify what you mean by container? We say in the spec that "A color3 value is associated with a color space ACEScg by default" and that "The assumed color space of all the color parameters .. by default .. is assumed to be ACEScg". So "in-gamut" is implied to mean in-gamut of that color space (or ACEScg if unspecified). Is that still under-specified in your view?
Yes right, so emission color should not be restricted to [0,1], but it seemed like according to our earlier discussion we had agreed that for all the other colors, which represent albedos or fractional tints, they should be restricted to [0,1] (regardless of the color space). Do you still agree with that? |
Yes, e.g., HDR values are considered in-gamut of their colourspace for example.
I would certainly be very specific, there is an infinity of gamuts and it does not cost much to add.
Yes! |
|
Sorry can you clarify what you mean by “there is an infinity of gamuts”? We say the color space must be specified (or is ACEScg by default). How can we be more specific that that? |
|
We are splitting hairs here but "gamut" by definition (Oxford Languages) is "the complete range or scope of something", what I'm saying is that the notes does not explicitly specifies it.
This is better because the "something" is specified explicitly in the sentence right next to "gamut" and you do not have to reach the end of the sentence to understand the full context. In theory, the i.e., portion of the sentence could be omitted and the sentence would be explicit by itself, I could only write:
|
This changelist merges v1.1 development from dev_1.1 to main, in preparation for marking the release of OpenPBR v1.1.
This reverts commit 4da98f6.
Adding here the finalized logo. This is almost identical to the one posted on Slack, except: - extremely small adjustment to the arrow head, to make it perfectly centered on and orthogonal to the stroke - SVG was optimized to remove redundant elements (e.g. gradients). Main logo is now only 10Kb. PNGs exported at 800dpi.
|
I modified this as follows:
|
|
@jstone-lucasfilm can be merged? |
Implements the change described in AcademySoftwareFoundation#229.
…oftwareFoundation#238) Rather than eliminating the `specular_weight` > 1 case (as proposed in AcademySoftwareFoundation#228), we discussed keeping this but fixing up the metal logic to ensure the Fresnel remains bounded. This makes the corresponding change needed in the spec. (Note that now the `specular_weight` parameter consistently, for both metal and dielectric, has soft-range $[0,1]$ and full range $[0, \infty]$). It would be good to double check that the behaviour of the metal looks reasonable for high `specular_weight` values (presumably, similar to the dielectric where the Fresnel saturates).
# Conflicts: # index.html # parametrization.md.html
…dation#218) Some minor changes are needed to improve the clarity of the wording (around the implementation of the coat details). I discovered these while using the spec myself to implement the Arnold version.
|
Note we added:
But the parametrization tables were not updated to make this change (despite the screenshots above?), so that is still to be done. |
AdrienHerubel
left a comment
AdrienHerubel
left a comment
There was a problem hiding this comment.
Need a clean rebase on top of 1.1.1
Adding here the finalized logo. This is almost identical to the one posted on Slack, except: - extremely small adjustment to the arrow head, to make it perfectly centered on and orthogonal to the stroke - SVG was optimized to remove redundant elements (e.g. gradients). Main logo is now only 10Kb. PNGs exported at 800dpi.
This reverts commit 4da98f6.
Implements the change described in AcademySoftwareFoundation#229.
…oftwareFoundation#238) Rather than eliminating the `specular_weight` > 1 case (as proposed in AcademySoftwareFoundation#228), we discussed keeping this but fixing up the metal logic to ensure the Fresnel remains bounded. This makes the corresponding change needed in the spec. (Note that now the `specular_weight` parameter consistently, for both metal and dielectric, has soft-range $[0,1]$ and full range $[0, \infty]$). It would be good to double check that the behaviour of the metal looks reasonable for high `specular_weight` values (presumably, similar to the dielectric where the Fresnel saturates).
…dation#218) Some minor changes are needed to improve the clarity of the wording (around the implementation of the coat details). I discovered these while using the spec myself to implement the Arnold version.
Implements the change described in AcademySoftwareFoundation#229. # Conflicts: # index.html # parametrization.md.html
Adding here the finalized logo. This is almost identical to the one posted on Slack, except: - extremely small adjustment to the arrow head, to make it perfectly centered on and orthogonal to the stroke - SVG was optimized to remove redundant elements (e.g. gradients). Main logo is now only 10Kb. PNGs exported at 800dpi.
This changelist merges v1.1 development from dev_1.1 to main, in preparation for marking the release of OpenPBR v1.1.
Adding here the finalized logo. This is almost identical to the one posted on Slack, except: - extremely small adjustment to the arrow head, to make it perfectly centered on and orthogonal to the stroke - SVG was optimized to remove redundant elements (e.g. gradients). Main logo is now only 10Kb. PNGs exported at 800dpi.
|
Can be closed, redone in #260. |
4 participants
Based on the interesting discussion in #149, it seems worth adding this side note: