Skip to content

Enable Zeltner sheen #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jstone-lucasfilm merged 2 commits into from
Jun 17, 2024
Merged

Enable Zeltner sheen #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7725611
Enable Zeltner sheen
jstone-lucasfilm Jun 11, 2024
ef7308b
Merge branch 'dev_1.1' into dev_1.1
jstone-lucasfilm Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/open_pbr_velvet.mtlx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
<input name="specular_roughness" type="float" value="0.8" />
<input name="fuzz_weight" type="float" value="1" />
<input name="fuzz_color" type="color3" value="0.4, 0.4, 0.4" />
<input name="fuzz_roughness" type="float" value="0.2" />
<input name="fuzz_roughness" type="float" value="0.5" />
Copy link
Copy Markdown

@theblackunknown theblackunknown Jun 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this empirical, or is there a closed form to fit Conty-Kulla on Zeltner one ?

Copy link
Copy Markdown
Member Author

@jstone-lucasfilm jstone-lucasfilm Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of a closed-form solution, but we can definitely put together a good approximation and include it in a future shader translation graph from standard_surface to open_pbr_surface.

For now, I'm just estimating the visual equivalent of the original settings with Zeltner sheen, in order to roughly maintain the look of the example material in the new model.

</open_pbr_surface>
</materialx>
2 changes: 1 addition & 1 deletion reference/open_pbr_surface.mtlx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,12 +558,12 @@
</layer>

<!-- Fuzz Layer -->
<!-- TODO: Add a new BSDF node for the selected fuzz model in OpenPBR -->
<sheen_bsdf name="fuzz_bsdf" type="BSDF">
<input name="weight" type="float" interfacename="fuzz_weight" />
<input name="color" type="color3" interfacename="fuzz_color" />
<input name="roughness" type="float" interfacename="fuzz_roughness" />
<input name="normal" type="vector3" interfacename="geometry_normal" />
<input name="mode" type="string" value="zeltner" />
</sheen_bsdf>
<layer name="fuzz_layer" type="BSDF">
<input name="top" type="BSDF" nodename="fuzz_bsdf" />
Expand Down
⚡