MaterialX: fix bug in thin-walled subsurface#251
Merged
jstone-lucasfilm merged 13 commits intoAcademySoftwareFoundation:dev_1.2from Jun 5, 2025
Merged
MaterialX: fix bug in thin-walled subsurface#251jstone-lucasfilm merged 13 commits intoAcademySoftwareFoundation:dev_1.2from
jstone-lucasfilm merged 13 commits intoAcademySoftwareFoundation:dev_1.2from
Conversation
This changelist updates the OpenPBR default example, matching its values to the latest default values of the shading model.
From 1.5 to 1.4. As this won't make much difference to the look in implementations that ignore the adjacent IORs of the film. But for those that take it into account, this will make the film visible rather than invisible by default (since `specular_ior` is 1.5 by default, and `coat_ior` 1.6).
This changelist enables Zeltner sheen in the reference implementation of OpenPBR, leveraging the new functionality in MaterialX 1.39. Additionally, the open_pbr_velvet.mtlx example has been updated to account for the visual differences between Conty-Kulla and Zeltner sheen.
…n#215) With links to - MaterialX web viewer running OpenPBR default material - OpenPBR-viewer project and web app
Following the discussion of AcademySoftwareFoundation#85.
This changelist updates the types associated with physical color values for subsurface scattering in OpenPBR, aligning with the conclusions of recent threads on ASWF Slack channels. - Change `subsurface_radius_scale` from a `vector3` to a `color3` in the specification, aligning with the MaterialX implementation of OpenPBR. - Change the `radius` input of `subsurface_bsdf` from a `vector3` to a `color3` in the MaterialX implementation, aligning with the current definition of the `subsurface_bsdf` node in MaterialX 1.39.
Also simplify graph
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Member
|
Sorry for the spam above, @portsmouth, which was my attempt to rebase the change to |
jstone-lucasfilm
approved these changes
May 27, 2025
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @portsmouth!
Just to double-check, do we want to include this in dev_1.2 or in dev_1.1.1?
Member
|
For now, let's merge this to its targeted 1.2 branch, and we can integrate it back to 1.1.1 if needed. |
jstone-lucasfilm
merged commit 3845bc1
into
AcademySoftwareFoundation:dev_1.2
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by Brian Sharpe of SideFX, there is a bug in the thin-walled subsurface, since
specular_coloris accounted for in both the BSDF weights and as an explicit multiplier.Also, the graph can be simplified a bit using the mix operation with a more carefully chosen weight.