-
Notifications
You must be signed in to change notification settings - Fork 35
Clarify orthonormalization policy for normals and tangents #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
portsmouth
wants to merge
8
commits into
AcademySoftwareFoundation:dev_1.2
Choose a base branch
from
portsmouth:clarify_orthonormalization_policy
base: dev_1.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
−11
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ef56f14
Clarify orthonormalization policy for normals and tangents
portsmouth bec80ae
Add more discussion of the normal inputs in the microfacet section.
portsmouth 3c27eb2
tweak
portsmouth bd03fa1
Merge branch 'dev_1.2' into clarify_orthonormalization_policy
portsmouth ef3e73a
Merge branch 'dev_1.2' into clarify_orthonormalization_policy
portsmouth 23dc991
Merge remote-tracking branch 'upstream/dev_1.2' into clarify_orthonor…
portsmouth b727791
Merge branch 'clarify_orthonormalization_policy' of https://github.co…
portsmouth 15bf2e1
Add note about Gram-Schmidt orthogonalization
portsmouth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to note, this is equivalent to Gram-Schmidt orthogonalization. We might as well state that.
Done in 15bf2e1