Make T_coat notation consistent#304
Open
portsmouth wants to merge 2 commits intoAcademySoftwareFoundation:dev_1.2from
Open
Make T_coat notation consistent#304portsmouth wants to merge 2 commits intoAcademySoftwareFoundation:dev_1.2from
portsmouth wants to merge 2 commits intoAcademySoftwareFoundation:dev_1.2from
Conversation
…tity
T_coat is a color3 (RGB) transmittance, consistent with the bold
notation already used for other RGB quantities in the spec such as
\mathbf{E}_b, \mathbf{B}, \mathbf{\Delta}.
This commit extends bold \mathbf{T}_coat notation (which was already
used in the Darkening section) to all other occurrences in the spec:
the coat layering formulas, the view-dependent absorption formula,
the reference implementation, and the emission formula.
In addition, the BRDF layering formulas in the reference implementation
are corrected to use \mathbf{T}^2_coat (reflected light traverses the
coat twice), while the emission formula correctly keeps \mathbf{T}_coat
(emission passes through only once).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
portsmouth
force-pushed
the
fix-Tcoat-notation
branch
from
92477d2 to
683c419
Compare
portsmouth
changed the title
portsmouth
changed the title
The file was removed in 8bf8248 ("Fix the coat darkening color shift") and is referenced in the Dielectric Base section of the spec. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
color3(RGB) transmittance, consistent with the bold notation already used for other RGB quantities in the spec such asExtends bold$\mathbf{T}_\mathrm{coat}$ notation (already present in the Darkening section) to all other occurrences: the coat layering formulas, the view-dependent absorption formula, the reference implementation, and the emission formula.
Corrects the BRDF layering formulas in the reference implementation to use$\mathbf{T}^2_\mathrm{coat}$ — reflected light traverses the coat twice (once incident, once outgoing).
Emission formula correctly keeps$\mathbf{T}_\mathrm{coat}$ (single-direction) — emission passes through the coat only once.
This also puts back in place the accidently deleted
dielectric_fresnel.svg.