chore(docker): add kraft-based demo#651
Merged
giuseppelillo merged 1 commit intomainfrom Feb 27, 2025
Merged
Conversation
jeqo
force-pushed
the
jeqo/kraft-demo
branch
from
712f57d to
826d60b
Compare
| KAFKA_RSM_CONFIG_STORAGE_AWS_ACCESS_KEY_ID: "minioadmin" | ||
| KAFKA_RSM_CONFIG_STORAGE_AWS_SECRET_ACCESS_KEY: "minioadmin" | ||
| volumes: | ||
| # These paths depend on gradle copyDistFiles task run on root directory |
Contributor
There was a problem hiding this comment.
Do we need to document somewhere that you need to first run this task before starting the compose?
Contributor
Author
There was a problem hiding this comment.
This is defined on the Makefile, anyway I added a note about it to the demo/README, PTAL
jeqo
force-pushed
the
jeqo/kraft-demo
branch
from
826d60b to
400609e
Compare
giuseppelillo
approved these changes
Feb 27, 2025
Changes: - Add a gradle task to move binaries to a docker directory - Build docker image from OSS kafka image, adding cache directory, and use binaries generated by Gradle. - Refactor make tasks to use a temporal container to run topic create/fill topic.
jeqo
force-pushed
the
jeqo/kraft-demo
branch
from
400609e to
8020567
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes #641