Skip to content

Support loading Google access token credentials#765

Merged
jeqo merged 1 commit intomainfrom
tvainika/google-access-token
Nov 5, 2025
Merged

Support loading Google access token credentials#765
jeqo merged 1 commit intomainfrom
tvainika/google-access-token

Conversation

@tvainika
Copy link
Copy Markdown
Contributor

If service account impersonation is used, then a plain access token is used for authentication.

@tvainika tvainika force-pushed the tvainika/google-access-token branch 2 times, most recently from bd1eb4e to 21ed348 Compare October 31, 2025 12:10
@tvainika tvainika marked this pull request as ready for review October 31, 2025 13:04
@tvainika tvainika requested a review from a team as a code owner October 31, 2025 13:04
@tvainika tvainika force-pushed the tvainika/google-access-token branch from 21ed348 to 53700d5 Compare November 4, 2025 10:48
@tvainika tvainika requested a review from Copilot November 4, 2025 12:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for GCS access token credentials in addition to the existing service account credentials. The main changes enable the system to accept JSON credentials with a single access_token field, which will be parsed and used to create GoogleCredentials.

  • Added Jackson databind dependency to parse JSON credentials
  • Implemented access token credential detection and handling in CredentialsBuilder
  • Added test coverage for access token credential flow
  • Updated documentation to describe the new credential format support

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
storage/gcs/build.gradle Added Jackson databind dependency for JSON parsing
storage/gcs/src/main/java/io/aiven/kafka/tieredstorage/storage/gcs/CredentialsBuilder.java Refactored credential parsing to support access token format via new getCredentialsFromBytes method
storage/gcs/src/main/java/io/aiven/kafka/tieredstorage/storage/gcs/GcsStorageConfig.java Updated configuration documentation to mention access token support
storage/gcs/src/test/java/io/aiven/kafka/tieredstorage/storage/gcs/ReloadableCredentialsProviderTest.java Added test case for access token credentials and fixed private key string formatting
storage/gcs/src/test/java/io/aiven/kafka/tieredstorage/storage/gcs/GcsCredentialsAutoReloadIntegrationTest.java Fixed private key string formatting for consistency
docs/configs.rst Updated documentation to mention access token credential format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tvainika tvainika force-pushed the tvainika/google-access-token branch from 53700d5 to a086432 Compare November 4, 2025 12:59
If service account impersonation is used, then a plain access token is
used for authentication.
@tvainika tvainika force-pushed the tvainika/google-access-token branch from a086432 to 4354af6 Compare November 5, 2025 11:43
@jeqo jeqo merged commit 4dcbde1 into main Nov 5, 2025
18 of 21 checks passed
@jeqo jeqo deleted the tvainika/google-access-token branch November 5, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants