Support loading Google access token credentials#765
Merged
Conversation
bd1eb4e to
21ed348
Compare
21ed348 to
53700d5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for GCS access token credentials in addition to the existing service account credentials. The main changes enable the system to accept JSON credentials with a single access_token field, which will be parsed and used to create GoogleCredentials.
- Added Jackson databind dependency to parse JSON credentials
- Implemented access token credential detection and handling in
CredentialsBuilder - Added test coverage for access token credential flow
- Updated documentation to describe the new credential format support
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| storage/gcs/build.gradle | Added Jackson databind dependency for JSON parsing |
| storage/gcs/src/main/java/io/aiven/kafka/tieredstorage/storage/gcs/CredentialsBuilder.java | Refactored credential parsing to support access token format via new getCredentialsFromBytes method |
| storage/gcs/src/main/java/io/aiven/kafka/tieredstorage/storage/gcs/GcsStorageConfig.java | Updated configuration documentation to mention access token support |
| storage/gcs/src/test/java/io/aiven/kafka/tieredstorage/storage/gcs/ReloadableCredentialsProviderTest.java | Added test case for access token credentials and fixed private key string formatting |
| storage/gcs/src/test/java/io/aiven/kafka/tieredstorage/storage/gcs/GcsCredentialsAutoReloadIntegrationTest.java | Fixed private key string formatting for consistency |
| docs/configs.rst | Updated documentation to mention access token credential format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
storage/gcs/src/main/java/io/aiven/kafka/tieredstorage/storage/gcs/CredentialsBuilder.java
Outdated
Show resolved
Hide resolved
storage/gcs/src/main/java/io/aiven/kafka/tieredstorage/storage/gcs/CredentialsBuilder.java
Show resolved
Hide resolved
53700d5 to
a086432
Compare
jeqo
reviewed
Nov 5, 2025
storage/gcs/src/main/java/io/aiven/kafka/tieredstorage/storage/gcs/CredentialsBuilder.java
Show resolved
Hide resolved
...t/java/io/aiven/kafka/tieredstorage/storage/gcs/GcsCredentialsAutoReloadIntegrationTest.java
Show resolved
Hide resolved
If service account impersonation is used, then a plain access token is used for authentication.
a086432 to
4354af6
Compare
jeqo
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If service account impersonation is used, then a plain access token is used for authentication.