feat: standardize strict type hints for context managers and settings#306
Open
rayrishu19-wq wants to merge 3 commits intoAlishahryar1:mainfrom
Open
feat: standardize strict type hints for context managers and settings#306rayrishu19-wq wants to merge 3 commits intoAlishahryar1:mainfrom
rayrishu19-wq wants to merge 3 commits intoAlishahryar1:mainfrom
Conversation
This commit improves type-safety and consistency across core, config, messaging, and api components. Reference Issue Alishahryar1#305.
Ported from Alishahryar1#289 to consolidate DX improvements into a single comprehensive PR. Reference Issue Alishahryar1#305.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes type hints across multiple components to improve maintainability and developer experience. Closes #305.
Changes:
TracebackTypehints toStrictSlidingWindowLimiter.__aexit__.Settings.AsyncIterator[None]return type toMessageTree.with_lock.AsyncIterator[None]return type tolifespan.These changes ensure consistency with the project's strict typing policy (
AGENTS.md) and provide better IDE support for core context managers.