Skip to content

chore: remove acr pull secret#18349

Merged
mirkoSekulic merged 1 commit intomainfrom
chore/remove-pull-secret
Mar 29, 2026
Merged

chore: remove acr pull secret#18349
mirkoSekulic merged 1 commit intomainfrom
chore/remove-pull-secret

Conversation

@mirkoSekulic
Copy link
Copy Markdown
Contributor

@mirkoSekulic mirkoSekulic commented Mar 29, 2026

Description

Verification

  • Related issues are connected (if applicable)
  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Summary by CodeRabbit

Release Notes

Chores

  • Removed image pull secret configuration from deployment charts, simplifying container registry authentication setup requirements.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5ff738d4-be86-4e99-9fe6-cccc1d986a58

📥 Commits

Reviewing files that changed from the base of the PR and between 0d1aa3a and e686f8e.

📒 Files selected for processing (2)
  • charts/altinn-designer/values.yaml
  • charts/altinn-repositories/values.yaml
💤 Files with no reviewable changes (2)
  • charts/altinn-designer/values.yaml
  • charts/altinn-repositories/values.yaml

📝 Walkthrough

Walkthrough

Two Helm chart configuration files have been updated by removing the image.imagePullSecret: acrsecret setting from their values, modifying the container registry authentication configuration for the altinn-designer and altinn-repositories charts.

Changes

Cohort / File(s) Summary
Helm Chart Configuration Updates
charts/altinn-designer/values.yaml, charts/altinn-repositories/values.yaml
Removed the image.imagePullSecret: acrsecret configuration entry from both chart values files, eliminating the previously specified Kubernetes image pull secret reference for container registry authentication.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A secret once pulled, now released into air,
Two charts lightened up, with registry care,
No acrsecret bound to their names anymore,
Simpler configurations unlock freedom's door! 🔐✨

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely unfilled; it contains only the template placeholders with no actual details about the changes, rationale, or verification completion. Fill in the Description section with details about why the ACR pull secret is being removed and complete the Verification checklist to confirm testing and build status.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change—removing the ACR pull secret configuration from Helm chart values files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-pull-secret

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mirkoSekulic mirkoSekulic added the approve You approve this PR. Use when: - Small changes - Already agreed upon - Async review label Mar 29, 2026
@mirkoSekulic mirkoSekulic merged commit 395d5a0 into main Mar 29, 2026
12 checks passed
@mirkoSekulic mirkoSekulic deleted the chore/remove-pull-secret branch March 29, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approve You approve this PR. Use when: - Small changes - Already agreed upon - Async review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant