feat(openapi): generator of an openapi extension project by kpanot · Pull Request #3800 · AmadeusITGroup/otter

kpanot · 2025-12-10T10:25:46Z

Proposed change

feat(openapi): generator of an openapi extension project

Related issues

- No issue associated -

nx-cloud · 2025-12-10T10:27:14Z

View your CI Pipeline Execution ↗ for commit dbfdd6f

Command	Status	Duration	Result
`nx run-many --target=test-e2e`	✅ Succeeded	2m 10s	View ↗
`nx run-many --tui=false --target=build --projec...`	✅ Succeeded	1s	View ↗
`nx run-many --target=build,build-swagger`	✅ Succeeded	16m 3s	View ↗
`nx affected --target=lint --configuration ci`	✅ Succeeded	15m 22s	View ↗
`nx affected --target=test --collectCoverage --c...`	✅ Succeeded	5m 7s	View ↗
`nx run ama-sdk-schematics:build-swagger`	✅ Succeeded	2m 29s	View ↗
`nx run-many --target=documentation`	✅ Succeeded	1m 32s	View ↗
`nx affected --target=package-github-action`	✅ Succeeded	2m 2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-14 03:55:53 UTC

codecov · 2025-12-10T10:30:53Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.16%. Comparing base (057863d) to head (dbfdd6f).
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

guilhermevrs · 2025-12-12T20:06:02Z

We are approaching 2026 and still I don't see tests in your PRs 🥲

packages/@ama-openapi/create/src/generate-extension.ts

packages/@ama-openapi/create/README.md

packages/@ama-openapi/create/templates/design-extension/README.md.template

kpanot · 2026-01-04T14:43:45Z

@guilhermevrs I am so happy to still seeing you doing my code review in 2026 :D, I wish you a very happy new year :).
Do not worry for the tests, the 3 initializers are already planned to be IT tested when finalized and fully aligned with the requirement from the teams using it.

fpaul-1A · 2026-02-17T07:17:31Z

packages/@ama-openapi/create-extension/README.md

+# Ama OpenAPI Create extension
+
+> [!WARNING]
+> [Experimental](https://github.com/AmadeusITGroup/otter/blob/main/README.md#experimental): This package is available in early access, it will be part of the v14 release.


Not sure how to understand this. Does it mean it will no longer be experimental in v14? If so, why even mention it?

Copy past from other package, I will update this one and the other in a separated PR

packages/@ama-openapi/create-extension/templates/README.md.template

fpaul-1A · 2026-02-17T07:28:12Z

packages/@o3r/core/package.json

-    "eslint-plugin-jest": "~29.12.0",
-    "eslint-plugin-jsdoc": "~61.7.0",
+    "eslint-plugin-jest": "~29.2.0",
+    "eslint-plugin-jsdoc": "~54.7.0",


Probably a mistake?

nop, it is applied by the harmonizer and seems aligned with the other deps

nx-cloud

❌ The fix was rejected

We fixed the TypeScript compilation error by changing the rootDir from "." to "./src" in the tsconfig.build.json file. This ensures TypeScript only compiles source files within the src directory and uses type definitions from workspace dependencies without attempting to compile their source files, which was causing the TS6059 and TS6307 errors.

Tip

✅ We verified this fix by re-running ama-openapi-create-extension:compile.

Warning

The suggested diff is too large to display here, but you can view it on Nx Cloud ↗

View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

fpaul-1A · 2026-02-17T10:42:30Z

packages/@ama-openapi/create-extension/README.md

+| `--target`, `-t` | `.` | Target directory where files will be generated. |
+| `--dependency-base-spec`, `-b` | - | Name of the NPM artifact to use as the dependency base specification (e.g. @my-org/specification). |
+
+The command will generate a directory with the same structure of the `design` command but will setup the repository to prepare the generation of 3 specification:


Suggested change

The command will generate a directory with the same structure of the `design` command but will setup the repository to prepare the generation of 3 specification:

The command will generate a directory with the same structure as the `design` command but will set up the repository to prepare the generation of 3 specifications:

vscaiceanu-1a · 2026-03-13T13:22:45Z

packages/@ama-openapi/create-extension/eslint.local.config.mjs

+
+export default [
+  {
+    name: '@ama-sdk/create/projects',


Suggested change

name: '@ama-sdk/create/projects',

name: '@ama-openapi/create-extension/projects',

vscaiceanu-1a · 2026-03-13T13:28:50Z

packages/@ama-openapi/create-extension/src/generate-template.ts

+ */
+export const generateExtension = async (options: CreateExtensionOptions) => {
+  await generateTemplate({ ...options });
+  await generateTemplate({ ...options, templatesDirectory: resolve(__dirname, '..', 'templates') });


why is generateTemplate called twice?

vscaiceanu-1a · 2026-03-13T13:30:59Z

packages/@ama-openapi/create-extension/src/generate-template.ts

+    'build:merge': 'redocly bundle filter-base && redocly join filtered-base server -o ./bundle/specification.yaml',
+    'retrieve-externals': 'ama-openapi install',
+    'watch:retrieve-externals': 'ama-openapi watch',
+    postinstall: 'ama-openapi install'


Suggested change

postinstall: 'ama-openapi install'

postinstall: 'npm run retrieve-externals'

vscaiceanu-1a · 2026-03-13T13:35:57Z

packages/@ama-openapi/create-extension/tsconfig.eslint.json

+  "include": [
+    "eslint*.config.mjs",
+    "testing/jest.config.it.js",
+    "testing/setup-jest.ts"


why are the jest specific files under tsconfig.eslint.json?

kpanot requested a review from a team as a code owner December 10, 2025 10:25

github-actions bot added enhancement New feature or request project:@ama-openapi/create labels Dec 10, 2025

cpaulve-1A reviewed Dec 15, 2025

View reviewed changes

packages/@ama-openapi/create/src/generate-extension.ts Outdated Show resolved Hide resolved

kpanot force-pushed the feature/openapi-extension-generator branch from c9a2d2b to 20b47fa Compare December 16, 2025 02:39

sdo-1A reviewed Dec 16, 2025

View reviewed changes

kpanot force-pushed the feature/openapi-extension-generator branch from 20b47fa to f9dabff Compare December 17, 2025 03:10

kpanot force-pushed the feature/openapi-extension-generator branch 2 times, most recently from 10bc1ce to af584a0 Compare January 4, 2026 14:33

kpanot force-pushed the feature/openapi-extension-generator branch from af584a0 to c70dbed Compare January 4, 2026 14:44

github-actions bot added project:@ama-sdk/schematics project:@o3r/core project:@ama-openapi/create-extension labels Jan 4, 2026

kpanot force-pushed the feature/openapi-extension-generator branch 2 times, most recently from b9fe5a0 to 9c86e5b Compare January 4, 2026 15:55

kpanot force-pushed the feature/openapi-extension-generator branch 2 times, most recently from b603a1d to 0dfb73c Compare February 17, 2026 07:14

fpaul-1A reviewed Feb 17, 2026

View reviewed changes

kpanot force-pushed the feature/openapi-extension-generator branch from 0dfb73c to 04c8be0 Compare February 17, 2026 07:31

github-actions bot added the project:@ama-styling/figma-extractor label Feb 17, 2026

kpanot force-pushed the feature/openapi-extension-generator branch 2 times, most recently from 1b6824f to 792a782 Compare February 17, 2026 07:45

This comment was marked as outdated.

Sign in to view

kpanot force-pushed the feature/openapi-extension-generator branch from 792a782 to e87a9a0 Compare February 17, 2026 08:08

nx-cloud bot reviewed Feb 17, 2026

View reviewed changes

feat(ama-openapi): create design project extension

dbfdd6f

kpanot force-pushed the feature/openapi-extension-generator branch from e87a9a0 to dbfdd6f Compare February 17, 2026 10:02

fpaul-1A reviewed Feb 17, 2026

View reviewed changes

vscaiceanu-1a reviewed Mar 13, 2026

View reviewed changes

	The command will generate a directory with the same structure of the `design` command but will setup the repository to prepare the generation of 3 specification:
	The command will generate a directory with the same structure as the `design` command but will set up the repository to prepare the generation of 3 specifications:

	name: '@ama-sdk/create/projects',
	name: '@ama-openapi/create-extension/projects',

	postinstall: 'ama-openapi install'
	postinstall: 'npm run retrieve-externals'

Conversation

kpanot commented Dec 10, 2025

Proposed change

Related issues

Uh oh!

nx-cloud bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

guilhermevrs commented Dec 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kpanot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

nx-cloud bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

❌ The fix was rejected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nx-cloud bot commented Dec 10, 2025 •

edited

Loading

codecov bot commented Dec 10, 2025 •

edited

Loading

kpanot commented Jan 4, 2026 •

edited

Loading

nx-cloud bot left a comment •

edited

Loading