feat(ama-sdk-generator): add guard function for extended definitions#4119
feat(ama-sdk-generator): add guard function for extended definitions#4119
Conversation
|
View your CI Pipeline Execution ↗ for commit d9465f1
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
❌ The fix was rejected
We updated the api.mustache template and the generated training-sdk/src/api/dummy/dummy-api.ts to restore the reviver import from import type to a regular import. Reviver functions like reviveFlight are used as runtime values in processCall, so import type — which is erased at compile time — causes a TS1361 error. This fix preserves import type for model/interface types while ensuring reviver functions remain as value imports.
Warning
❌ We could not verify this fix.
Suggested Fix changes
diff --git a/packages/@ama-sdk/schematics/schematics/typescript/core/openapi-codegen-typescript/src/main/resources/typescriptFetch/api/api.mustache b/packages/@ama-sdk/schematics/schematics/typescript/core/openapi-codegen-typescript/src/main/resources/typescriptFetch/api/api.mustache
index 518081a63..a497512c1 100644
--- a/packages/@ama-sdk/schematics/schematics/typescript/core/openapi-codegen-typescript/src/main/resources/typescriptFetch/api/api.mustache
+++ b/packages/@ama-sdk/schematics/schematics/typescript/core/openapi-codegen-typescript/src/main/resources/typescriptFetch/api/api.mustache
@@ -2,7 +2,7 @@
{{#imports}}
import type { {{import}} } from '../../models/base/{{#kebabCase}}{{import}}{{/kebabCase}}/index';
{{#keepRevivers}}
-import type { revive{{import}} } from '../../models/base/{{#kebabCase}}{{import}}{{/kebabCase}}/{{#kebabCase}}{{import}}{{/kebabCase}}.reviver';
+import { revive{{import}} } from '../../models/base/{{#kebabCase}}{{import}}{{/kebabCase}}/{{#kebabCase}}{{import}}{{/kebabCase}}.reviver';
{{/keepRevivers}}
{{/imports}}
import { Api, ApiClient, ApiTypes, computePiiParameterTokens, isJsonMimeType, ParamSerializationOptions, RequestBody, RequestMetadata, Server, selectServerBasePath, utils } from '@ama-sdk/core';
diff --git a/packages/@o3r-training/training-sdk/src/api/dummy/dummy-api.ts b/packages/@o3r-training/training-sdk/src/api/dummy/dummy-api.ts
index ae4c170b4..c1c2253c2 100644
--- a/packages/@o3r-training/training-sdk/src/api/dummy/dummy-api.ts
+++ b/packages/@o3r-training/training-sdk/src/api/dummy/dummy-api.ts
@@ -1,5 +1,5 @@
import type { Flight } from '../../models/base/flight/index';
-import type { reviveFlight } from '../../models/base/flight/flight.reviver';
+import { reviveFlight } from '../../models/base/flight/flight.reviver';
import { Api, ApiClient, ApiTypes, computePiiParameterTokens, ParamSerializationOptions, RequestBody, RequestMetadata, Server, selectServerBasePath, } from '@ama-sdk/core';
import { SDK_SERVERS } from '../../constants/servers';
/** Parameters object to DummyApi's dummyGet function */
🎓 Learn more about Self-Healing CI on nx.dev
...ript/core/openapi-codegen-typescript/src/main/resources/typescriptFetch/model/model.mustache
Outdated
Show resolved
Hide resolved
ff5d358 to
8ed45bf
Compare
packages/@o3r-training/training-sdk/src/models/base/flight/flight.ts
Outdated
Show resolved
Hide resolved
feat(ama-sdk-generator): enhance extended model definition with discriminator literal type feat(ama-sdk-generator): add discriminator extended list
8ed45bf to
d9465f1
Compare
| --radius-10: 10px; | ||
| --radius-25: 25px; | ||
| --spacing-0: 0px; | ||
| --spacing-0: 0; |
There was a problem hiding this comment.
It seems to not be related to your PR, maybe it can be done in another PR
There was a problem hiding this comment.
This is done by the build process.
I open a dedicated PR: #4130
Proposed change
feat(ama-sdk-generator): enhance extended model definition with discriminator literal type
feat(ama-sdk-generator): add discriminator extended list
feat(ama-sdk-generator): add dynamic array type support option
Related issues
- No issue associated -