Add a setter to patch#674
Merged
Merged
Conversation
jph00
requested changes
Mar 24, 2025
Contributor
jph00
left a comment
jph00
left a comment
There was a problem hiding this comment.
Looks great! I suspect you can collapse your implementation down to one line if you follow my suggestion - I don't think we need all that extra ceremony, since python will already raise a suitable exception afaik.
Co-authored-by: Jeremy Howard <j@howard.fm>
Contributor
|
It looks like you might have forgotten to update the notebook with my suggestion? AFAICT it's only in the .py file, which means it'll be overwritten next time someone exports. |
Contributor
Author
|
I am very sorry about that. I forgot to update the notebook. I thought I could make changes on github, but I was wrong. I will make corrections. |
Contributor
Author
|
I make the corrections, and it is good to go. I appreciate your patience. |
Contributor
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a setter to
patch_toandpatchwithset_prop=True.Here are the changes:
setteris limited to classes that already have a property with the same name.AttributeErrorif there is no property with the name.