Skip to content

allow saving of file into directory and clean up the code#9

Merged
jph00 merged 2 commits into
mainfrom
dynamic_docs_dir
Sep 13, 2024
Merged

allow saving of file into directory and clean up the code#9
jph00 merged 2 commits into
mainfrom
dynamic_docs_dir

Conversation

@hamelsmu

@hamelsmu hamelsmu commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

This PR does the following:

  1. Cleans up the code by using get_config
  2. Allows you to save the file into the right nbdev directory based upon the settings.ini file.

This PR is tightly coupled to AnswerDotAI/fastcore#624

@hamelsmu hamelsmu marked this pull request as ready for review September 13, 2024 22:40
@hamelsmu hamelsmu requested a review from jph00 September 13, 2024 22:40
@jph00

jph00 commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

Much better! :D

@jph00 jph00 merged commit 8055bdb into main Sep 13, 2024
@jph00 jph00 added the enhancement New feature or request label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants