[Bug]: TimeSpan -0.001 in TimeoutRejectedException

[czmirek]

Describe the bug

For the following code:

PolicyResult result = await Policy.TimeoutAsync(5).ExecuteAndCaptureAsync(async (ct) =>
{
    await Task.Delay(TimeSpan.FromSeconds(10), ct);
}, CancellationToken.None);

Console.WriteLine(((TimeoutRejectedException)result.FinalException).Timeout);
Console.ReadLine();

Expected behavior

I expect the console output to be

00:00:05.0000000

Or at least something within reasonable error around the value of 5 seconds.

Actual behavior

It is instead -00:00:00.0010000.

Polly version

8.6.4

.NET Version

.NET 10

Anything else

I hope this is not me misunderstanding the usage...but honestly I have no idea where the value -0.001 seconds is coming from.

[peter-csala]

Thanks for providing an example to ease the reproduction of the bug.

---

It seems like in the V7's Timeout policy the Timeout property is not set explicitly:

Polly/src/Polly/Timeout/AsyncTimeoutEngine.cs

Line 49 in 0fb7b98

throw new TimeoutRejectedException("The delegate executed asynchronously through TimeoutPolicy did not complete within the timeout.", ex);

In contrast, in the V8's Timeout strategy the Timeout property is set:

Polly/src/Polly.Core/Timeout/TimeoutResilienceStrategy.cs

Lines 83 to 86 in 0fb7b98

	var timeoutException = new TimeoutRejectedException(
	$"The operation didn't complete within the allowed timeout of '{timeout}'.",
	timeout,
	e);

So, the bug shows the default value of the Timeout

[peter-csala]

I can work on this issue at the beginning of December, if there is no other volunteer.

[martincostello]

If no one's picked it up by the time it rises to the top of my TODO pile I was going to just pick it up myself as it should be trivial.

[github-actions]

Thanks for creating this issue @czmirek - the associated changes have been published as part of version 8.6.5 📦, which is now available from NuGet.org 🚀