Skip to content

Respect override for PipelineExecuting and PipelineExecuted#2752

Merged
martincostello merged 6 commits into
App-vNext:mainfrom
peter-csala:BUG/2750
Sep 25, 2025
Merged

Respect override for PipelineExecuting and PipelineExecuted#2752
martincostello merged 6 commits into
App-vNext:mainfrom
peter-csala:BUG/2750

Conversation

@peter-csala

@peter-csala peter-csala commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Pull Request

The issue or feature being addressed

Details on the issue fix or feature implementation

  • Added code to respect SeverityProvider's overrides for PipelineExecuting and PipelineExecuted
  • Added a bit of documentation
  • Removed the explicit LogLevel check
  • Added unit tests to cover the new code and the LogLevel checks

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov

codecov Bot commented Sep 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@03e3fc6). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2752   +/-   ##
=======================================
  Coverage        ?   96.15%           
=======================================
  Files           ?      309           
  Lines           ?     7123           
  Branches        ?     1005           
=======================================
  Hits            ?     6849           
  Misses          ?      221           
  Partials        ?       53           
Flag Coverage Δ
linux 96.15% <100.00%> (?)
macos 96.15% <100.00%> (?)
windows 96.14% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peter-csala peter-csala marked this pull request as ready for review September 25, 2025 12:18
Comment thread docs/advanced/telemetry.md Outdated
Comment thread docs/advanced/telemetry.md Outdated
Co-authored-by: Martin Costello <martin@martincostello.com>
@martincostello martincostello enabled auto-merge (squash) September 25, 2025 17:33
@martincostello martincostello merged commit 5f9462d into App-vNext:main Sep 25, 2025
27 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution @peter-csala - the changes from this pull request have been published as part of version 8.6.4 📦, which is now available from NuGet.org 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants