Skip to content

Log fold change calculation errors #41

@yashd94

Description

@yashd94
  1. guess_is_log in _utils.py does not work correctly, and returns FALSE where our data is in logscale. This results in the is_log1p flag being set incorrectly.

  2. _fold_change in _single_cell.py does not account for the is_log1p flag, which results in the fold change function using division instead of subtraction in the case where data is already in logscale. The fix is to pass a corrected is_log1p flag explicitly to the _fold_change function, and toggling between division and subtraction on the basis of this flag.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions