Skip to content

alttp: fix instant option of menu_speed setting being a list#6230

Open
RubixDev wants to merge 1 commit into
ArchipelagoMW:mainfrom
RubixDev:fix-alttp-menu-speed
Open

alttp: fix instant option of menu_speed setting being a list#6230
RubixDev wants to merge 1 commit into
ArchipelagoMW:mainfrom
RubixDev:fix-alttp-menu-speed

Conversation

@RubixDev

Copy link
Copy Markdown

What is this fixing or adding?

fixes #6229

How was this tested?

not yet at all, but seems like a tiny change

If this makes graphical changes, please attach screenshots.

N/A

@RubixDev RubixDev requested a review from Berserker66 as a code owner May 27, 2026 10:27
@github-actions github-actions Bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label May 27, 2026

@duckboycool duckboycool left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a tuple, not a list.
Fixes error if you have menuspeed: 1 in yaml for instance.

Also appears to be the only instance of this across core games.

@duckboycool duckboycool added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: "Instant Menu Speed" option in alttp is mistakenly a list and not an int

3 participants