[CommonClient] Reset session state when connecting to a different room or slot#6231
Open
gerbiljames wants to merge 1 commit into
Open
[CommonClient] Reset session state when connecting to a different room or slot#6231gerbiljames wants to merge 1 commit into
gerbiljames wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
affects: core
github-actions
Bot
added
the
waiting-on: peer-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This resets various pieces of CommonClient state when a change in session "identity" is detected. Session identity is defined as the combination of seed name, team and slot.
This also hoists
server_seed_nameout ofBizhawkContextand intoCommonContext.How was this tested?
Tested by sending a location from Pokemon Blue then loading a Pokemon Emerald ROM for the same multiworld in the same emulator, then sending a location from that.
If this makes graphical changes, please attach screenshots.