Core: fix Set import#6235
Open
beauxq wants to merge 1 commit into
Open
Conversation
mistake made in pr ArchipelagoMW#5048 ArchipelagoMW#5048 (comment)
github-actions
Bot
added
affects: core
Merged
duckboycool
approved these changes
May 31, 2026
duckboycool
left a comment
duckboycool
left a comment
Collaborator
There was a problem hiding this comment.
I think it might make more sense to just revert to importing AbstractSet from typing for now instead of manually aliasing collections.abc.Set, but I can confirm the mistake here and that this resolves the type checker errors caused by this.
Jouramie
approved these changes
Jun 4, 2026
Jouramie
added
waiting-on: core-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
mistake made in pr #5048
#5048 (comment)
Also see https://docs.astral.sh/ruff/rules/unaliased-collections-abc-set-import/ for more information.
How was this tested?
just looking at type checking a little bit
counting on CI tests