Validate non-negative (local_)early_items as well as [0, 0]#6242
Open
bbernardoni wants to merge 1 commit into
Open
Validate non-negative (local_)early_items as well as [0, 0]#6242bbernardoni wants to merge 1 commit into
bbernardoni wants to merge 1 commit into
Conversation
github-actions
Bot
added
affects: core
bbernardoni
force-pushed
the
early_items_validation
branch
from
1efc809 to
dc40ac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Validate that
early_itemsandlocal_early_itemscounts are non-negative by raising a ValueError. Also validate that both are not zero for any player, item combination (and ignore in that case).Previously, a count of
[0, 0]was decremented to[-1, 0]and then compared to[0, 0]. Since they are unequal, the code would proceed to place all of that item in the itempool.How was this tested?
Unit tests passed.