The Messenger: Add locations to shutting down the generators in Elementals Skyland#6252
Open
Jouramie wants to merge 4 commits into
Open
The Messenger: Add locations to shutting down the generators in Elementals Skyland#6252Jouramie wants to merge 4 commits into
Jouramie wants to merge 4 commits into
Conversation
Collaborator
Author
|
That failing test seems to be a flaky, unrelated to these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This adds 4 locations in the Elemental Skylands, sent by shutting down the generators. It also adds a Progressive Generator Shutdown item to deactivate each generator one by one. Four of copies of this item should be added to the itempool.
To avoid making the region too linear, the generator doors still open when breaking the lanterns (sending the location), except in the fire island generator room. There, you need all four Progressive Generator Shutdown to unlock the door. So it essentially only gates the Key of Symbiosis location and the right exit behind receiving the items.
The doors in each room also automatically open when receiving enough Progressive Generator Shutdown. This is however only useful on the air island where you can backtrack from the generator shop or the seal checkpoint, if you land a portal rando there.
How was this tested?
I played it in an async with friends, worked great! See also the PR on the mod side, there are a bunch of videos. alwaysintreble/TheMessengerRandomizerModAP#23
If this makes graphical changes, please attach screenshots.
N/A