Wargroove: Add item groups#6254
Conversation
|
I've never played Wargroove, and this isn't a hard-and-fast rule, but usually I see Item Name Groups pluralized (e.g. "Bows" in ALttP, "Crystal Hearts" in Celeste (Open World)). I'd defer to the maintainer's opinion on the matter, but that's something to consider changing to align with. |
|
I don't think Finals in it's plural form makes sense here. So I think the phrase"Final Items" is fine. The other classifications could probably be changed to say events, units, etc. There's a Wargroove 2 PR which I merged that has a similar setup to this. Could a second PR be created to that to add plurality to the groups. Final can remain in the singular form. I do believe that item type field is used elsewhere in the code. Definitely double check the client/world code for it in both Wargroove 1 and 2. I was unaware these were all supposed to be in plural form. Apologies for merging the Wargroove 2 PR so quickly. |
FlySniper
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
|
I've pluralized all of the item group names, with the final mission items as "Final Items". I've opted to have the pluralization done when generating groups rather than modifying the item data. |
What is this fixing or adding?
This adds item groups to Wargroove. The item groups added are units (named "Unit"), event items that don't unlock the final mission (named "Event"), event items that unlock the final mission (named "Final"), factions (named "Faction"), and filler boosts (named "Boost").
How was this tested?
I generated a test seed, set hint cost to 0, and then hinted each item group. I verified that the hinted items matched the expected contents of each item group.
If this makes graphical changes, please attach screenshots.
This does not make graphical changes.