Skip to content

Wargroove: Add item groups#6254

Open
rosen200 wants to merge 2 commits into
ArchipelagoMW:mainfrom
rosen200:main
Open

Wargroove: Add item groups#6254
rosen200 wants to merge 2 commits into
ArchipelagoMW:mainfrom
rosen200:main

Conversation

@rosen200

@rosen200 rosen200 commented Jun 7, 2026

Copy link
Copy Markdown

What is this fixing or adding?

This adds item groups to Wargroove. The item groups added are units (named "Unit"), event items that don't unlock the final mission (named "Event"), event items that unlock the final mission (named "Final"), factions (named "Faction"), and filler boosts (named "Boost").

How was this tested?

I generated a test seed, set hint cost to 0, and then hinted each item group. I verified that the hinted items matched the expected contents of each item group.

If this makes graphical changes, please attach screenshots.

This does not make graphical changes.

@github-actions github-actions Bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 7, 2026
@duckboycool duckboycool added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Jun 7, 2026
@PoryGone

PoryGone commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

I've never played Wargroove, and this isn't a hard-and-fast rule, but usually I see Item Name Groups pluralized (e.g. "Bows" in ALttP, "Crystal Hearts" in Celeste (Open World)). I'd defer to the maintainer's opinion on the matter, but that's something to consider changing to align with.

@FlySniper

Copy link
Copy Markdown
Collaborator

I don't think Finals in it's plural form makes sense here. So I think the phrase"Final Items" is fine. The other classifications could probably be changed to say events, units, etc. There's a Wargroove 2 PR which I merged that has a similar setup to this. Could a second PR be created to that to add plurality to the groups. Final can remain in the singular form.

I do believe that item type field is used elsewhere in the code. Definitely double check the client/world code for it in both Wargroove 1 and 2.

I was unaware these were all supposed to be in plural form. Apologies for merging the Wargroove 2 PR so quickly.

@FlySniper FlySniper left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@rosen200

rosen200 commented Jun 7, 2026

Copy link
Copy Markdown
Author

I've pluralized all of the item group names, with the final mission items as "Final Items". I've opted to have the pluralization done when generating groups rather than modifying the item data.

@ScipioWright ScipioWright removed the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Jun 8, 2026

@ScipioWright ScipioWright left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants