core/webhost: Option group descriptions#6261
Conversation
…ay in webhost and yaml templates
|
I believe this is missing changes to Option Creator to display these? |
I don't use options creator myself so I'm not sure I'd be able to do it correctly. Though I noted that #6216 switches options creator to using the same |
…stardew Option group descriptions for Stardew Valley
|
Merged in some stardew valley descriptions provided by @agilbert1412 / KaitoKid. Noting his feedback:
|
agilbert1412
left a comment
There was a problem hiding this comment.
I added my own descriptions and tested them on webhost. It works and looks good.
|
Failed unit tests are unrelated, from Celeste (Open World). |
|
Experimented with adding group descriptions to OptionCreator in this commit on this branch. Not updating this PR with it as the branch includes the changes from #6216, so one these PRs should merge first. I'm still not great at kivy, and I find that everything becomes horribly laggy when things can resize, so I'm not happy with how it turned out. But it functions. Detailed notes with pictures are on the discord thread. |

What is this fixing or adding?
Adding descriptions to option groups. These extra bits of documentation get included in yaml templates and the webhost under the option group header. Option groups without a description are unaffected.
I've made a #general-suggestions thread on the discord, Option Group Descriptions for faster communication.
Adding option group descriptions to the Starcraft 2 options. These are targeted at some of the most common issues players come to us for help on getting their yamls working.
Note that this PR changes the return type of Options.get_option_groups() to also return descriptions. I updated all usages so this is fine with current main, but there will be a conflict with #6216.
A note on newlines
One of the common pain points for my own dev when working with options descriptions and help text is that the same source is used for both yaml and webhost, with completely different display characteristics. Newlines get abandoned on webhost, and the full description gets crammed into a tiny box; whereas yaml preserves newlines, has no line wrap, has more space for description, and also wants extra detail wherever particular strings are expected but not provided by the template.
To try and give some amount of targeted control, I've made the browser displays only substitute
<br>tags on double-newlines. This means a single newline can be used to ensure a line wrap in yaml only, without creating a paragraph break in HTML.How was this tested?
If this makes graphical changes, please attach screenshots.
yaml
Options page
Weighted options page