Support UsdPrimvarReader_float2 shader returning the "st" variable#1522
Merged
sebastienblor merged 2 commits intoAutodesk:masterfrom May 9, 2023
Merged
Support UsdPrimvarReader_float2 shader returning the "st" variable#1522sebastienblor merged 2 commits intoAutodesk:masterfrom
sebastienblor merged 2 commits intoAutodesk:masterfrom
Conversation
cpichard
approved these changes
May 9, 2023
This was referenced Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
When we translate a UsdPrimvarReader_float2 prim, instead of a user_data shader reading "st" or "uv" coordinates, we want a utility shader that will simply return the uv builtin coordinates
Adding test_1521 with that use case
Issues fixed in this pull request
Fixes #1521