Skip to content

Fix issues with ShadowDOM Locators in nested context #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n1xan merged 2 commits into from
Apr 15, 2025
Merged

Fix issues with ShadowDOM Locators in nested context #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2fd655
fix issue in shadowDom locators
Apr 15, 2025
e4b645b
Merge remote-tracking branch 'refs/remotes/origin/main' into navramov_MM
Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bellatrix.web/src/main/java/solutions/bellatrix/web/components/WebComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,12 +838,12 @@ protected <TComponent extends WebComponent, TFindStrategy extends FindStrategy>
return componentList;
}

private boolean inShadowContext() {
public boolean inShadowContext() {
var component = this;

while (component != null) {
if (component instanceof ShadowRoot) return true;
while (component != null && component.getParentComponent() != null) {
component = component.getParentComponent();
if (component instanceof ShadowRoot) return true;
}

return false;
Expand Down
21 changes: 4 additions & 17 deletions ...trix.web/src/main/java/solutions/bellatrix/web/components/shadowdom/ShadowDomService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,9 @@

package solutions.bellatrix.web.components.shadowdom;

import lombok.SneakyThrows;
import lombok.experimental.UtilityClass;
import org.jsoup.Jsoup;
import org.jsoup.nodes.Element;
import org.jsoup.select.Elements;
import org.openqa.selenium.By;
import solutions.bellatrix.core.configuration.ConfigurationService;
import solutions.bellatrix.core.utilities.HtmlService;
import solutions.bellatrix.core.utilities.InstanceFactory;
import solutions.bellatrix.core.utilities.Ref;
import solutions.bellatrix.core.utilities.Wait;
Expand All @@ -32,11 +27,9 @@

import java.time.Duration;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Stack;
import java.util.concurrent.Callable;
import java.util.stream.Collectors;

@UtilityClass
public class ShadowDomService {
Expand Down Expand Up @@ -198,18 +191,14 @@ private static int getNestedLevel(WebComponent component) {
}

private static String retraceParentShadowRoots(WebComponent component) {
if (getNestedLevel(component) > 1) {
if (getNestedLevel(component) > 1 && component.inShadowContext()) {
var parent = component.getParentComponent();

Stack<String> findStrategies = new Stack<>();

checkIfCss(component.getFindStrategy());

findStrategies.push(component.getFindStrategy().getValue());

while (parent instanceof ShadowRoot) {
checkIfCss(parent.getFindStrategy());

while (parent instanceof ShadowRoot && parent.inShadowContext()) {
findStrategies.push(CHILD_COMBINATOR + SHADOW_ROOT_TAG + CHILD_COMBINATOR);
findStrategies.push(parent.getFindStrategy().getValue());

Expand All @@ -227,12 +216,10 @@ private static String retraceParentShadowRoots(WebComponent component) {
}
}

private static void checkIfCss(FindStrategy findStrategy) {
private static boolean checkIfCss(FindStrategy findStrategy) {
var strategyType = findStrategy.convert();

if (strategyType instanceof By.ByLinkText || strategyType instanceof By.ByPartialLinkText) {
throw new IllegalArgumentException("Inside Shadow DOM, there cannot be anything different than CSS locator.");
}
return !(strategyType instanceof By.ByLinkText) && !(strategyType instanceof By.ByPartialLinkText) && !(strategyType instanceof By.ByXPath);
}

private static String convertToCssOrXpath(FindStrategy findStrategy) {
Expand Down
⚡