Skip to content

Add Mobile Properties #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n1xan merged 4 commits into from
Jul 29, 2025
Merged

Add Mobile Properties #78

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d419e22
Do not wait when finding multiple elements
Apr 29, 2025
f7b294d
Merge remote-tracking branch 'refs/remotes/origin/main' into navramov_MM
Jul 29, 2025
f10bf7e
add ios properties in config
Jul 29, 2025
5ea8433
fix comment
Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bellatrix.ios/src/main/java/solutions/bellatrix/ios/configuration/IOSSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public class IOSSettings {
@Getter @Setter private String defaultIOSVersion;
@Getter @Setter private Boolean downloadDemoApps;
@Getter @Setter private String serviceUrl;
@Getter @Setter private String deviceIdentifier;

@Getter @Setter private List<GridSettings> gridSettings;

Expand Down
1 change: 1 addition & 0 deletions bellatrix.ios/src/main/java/solutions/bellatrix/ios/configuration/TimeoutSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public class TimeoutSettings {
@Getter @Setter private long elementWaitTimeout;
@Getter @Setter private long sleepInterval;
@Getter @Setter private long validationsTimeout;
@Getter @Setter private long webviewConnectTimeout;
@Getter @Setter private long elementToBeVisibleTimeout;
@Getter @Setter private long elementToExistTimeout;
@Getter @Setter private long elementToNotExistTimeout;
Expand Down
2 changes: 2 additions & 0 deletions bellatrix.ios/src/main/java/solutions/bellatrix/ios/infrastructure/DriverService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ private static IOSDriver initializeDriverGridMode(GridSettings gridSettings) {
caps.setAutomationName(AutomationName.IOS_XCUI_TEST);
caps.setPlatformVersion(getAppConfiguration().getIosVersion());
caps.setDeviceName(getAppConfiguration().getDeviceName());
caps.setUdid(ConfigurationService.get(IOSSettings.class).getDeviceIdentifier());
caps.setWebviewConnectTimeout(Duration.ofSeconds(ConfigurationService.get(IOSSettings.class).getTimeoutSettings().getWebviewConnectTimeout()));

try {
var driver = new IOSDriver(new URL(gridSettings.getUrl()), caps);
Expand Down
2 changes: 1 addition & 1 deletion bellatrix.web/src/main/java/solutions/bellatrix/web/components/WebComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ protected <TComponent extends WebComponent, TFindStrategy extends FindStrategy>

protected <TComponent extends WebComponent, TFindStrategy extends FindStrategy> List<TComponent> createAll(Class<TComponent> componentClass, TFindStrategy findStrategy) {
CREATING_ELEMENTS.broadcast(new ComponentActionEventArgs(this));
findElement();
Copy link
Copy Markdown
Collaborator Author

@n1xan n1xan Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

// findElement();

List<TComponent> componentList = new ArrayList<>();

Expand Down
2 changes: 2 additions & 0 deletions framework-tests/bellatrix.ios.tests/src/main/resources/testFrameworkSettings.dev.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"defaultDeviceName": "iPhone 6",
"defaultIosVersion": "11.3",
"defaultBrowser": "Safari",
"deviceIdentifier": "4005808588763",
"defaultAppPath": "${user.home}/TestApp.app.zip",
"artificialDelayBeforeAction": "0",
"automaticallyScrollToVisible": "false",
Expand All @@ -22,6 +23,7 @@
"elementWaitTimeout": "30",
"sleepInterval": "1",
"waitForPartialUrl": "30",
"webviewConnectTimeout": 60,
"validationsTimeout": "30",
"elementToBeVisibleTimeout": "30",
"elementToExistTimeout": "30",
Expand Down
2 changes: 2 additions & 0 deletions framework-tests/bellatrix.ios.tests/src/main/resources/testFrameworkSettings.qa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"defaultDeviceName": "iPhone 6",
"defaultIosVersion": "11.3",
"defaultBrowser": "Safari",
"deviceIdentifier": "4005808588763",
"defaultAppPath": "${user.home}/TestApp.app.zip",
"artificialDelayBeforeAction": "0",
"automaticallyScrollToVisible": "false",
Expand All @@ -21,6 +22,7 @@
"implicitWaitTimeout": "5",
"elementWaitTimeout": "30",
"sleepInterval": "1",
"webviewConnectTimeout": 60,
"waitForPartialUrl": "30",
"validationsTimeout": "30",
"elementToBeVisibleTimeout": "30",
Expand Down
⚡