Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 4ba0b2a. ♻️ This comment has been updated with latest results. |
| @@ -54,7 +54,7 @@ private static void EnsureInitialized() | |||
| return; | |||
|
|
|||
| var llmSettings = ConfigurationService.GetSection<LargeLanguageModelsSettings>(); | |||
| if (llmSettings == null) | |||
| if (llmSettings is null or { EnableSelfHealing: false, EnableSmartFailureAnalysis: false }) | |||
There was a problem hiding this comment.
is it okay to use the old syntax where we use ==, etc?
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\Bellatrix.LLM\Bellatrix.LLM.csproj" /> |
There was a problem hiding this comment.
are these additions on purpose? You are planning to use AWS?
There was a problem hiding this comment.
this is for the LLM services
| using Bellatrix.Web.Extensions; | ||
|
|
||
| namespace Bellatrix.Web.Extensions.Controls.Controls.EventHandlers; | ||
| namespace Bellatrix.DynamicTestCases.core; |
There was a problem hiding this comment.
it seems somewhere we have a namespace that is not following the nameconvention for PascalCase? "core" with not capital?> I mean it is fine to be like that I just noticed it.
| <ProjectReference Include="..\Bellatrix.AWS\Bellatrix.AWS.csproj" /> | ||
| <ProjectReference Include="..\Bellatrix.CognitiveServices\Bellatrix.CognitiveServices.csproj" /> | ||
| <ProjectReference Include="..\Bellatrix.Core\Bellatrix.Core.csproj" /> | ||
| <ProjectReference Include="..\Bellatrix.DynamicTestCases\Bellatrix.DynamicTestCases.csproj" /> |
There was a problem hiding this comment.
I don't fully understand what we are doing here since here we remove them but at the bottom file we have usings from dynamic test cases?
|
|
||
| public static partial class AppExtensions | ||
| { | ||
| extension(App _) |
There was a problem hiding this comment.
what is this syntax extension doing? I am seeing it for the first time is this something new from new C#?
| public void MakeTextExtractionFromPDF() | ||
| { | ||
| var textSnippets = App.ComputerVision.ExtractOCRTextFromLocalFile("sampleinvoice.pdf"); | ||
| var textSnippets = App.ComputerVision().ExtractOCRTextFromLocalFile("sampleinvoice.pdf"); |
There was a problem hiding this comment.
it seems it is already possible in C# 14 to have extension property: using System.Drawing;
public static class PointExtensions
{
extension(Point)
{
public static Point Origin => Point.Empty;
}
}
There was a problem hiding this comment.
yes - I fixed it everywhere
|
|
||
| public static partial class AppExtensions | ||
| { | ||
| public static LighthouseService Lighthouse(this App app) |
There was a problem hiding this comment.
same -> maybe it is better to make it extension property so that it is aligned with the rest.
| { | ||
| extension(App app) | ||
| { | ||
| public DynamicTestCasesService TestCases() |
| @@ -0,0 +1,72 @@ | |||
| Reference | Version | License Type | License | |||
| --------------------------------------------------------|-----------------------|---------------------|----------------------------------------------------------------------------------------------- | |||
| Allure.Commons | 3.5.0.73 | | https://www.nuget.org/packages/Allure.Net.Commons/2.14.1/License | |||
There was a problem hiding this comment.
that looks awsome! Good job! you can check btw the new format that I told you that Hero are using with common directory file for dependencies maybe later we can use it so that we can check all versions since in some projects we use different versions of some of the libraries.
3 participants
No description provided.