Feat/unit testing commands#57
Merged
teo-nikolov merged 12 commits intoAutomateThePlanet:mainfrom Mar 6, 2026
Merged
Conversation
Collaborator
|
Hi @yuri-byte, thank you for this PR! It's really helpful and well done! Will you be able to update the commit messages to include prefixes to follow Conventional Commits format? Our
You can update commits using |
teo-nikolov
requested changes
Mar 6, 2026
…n and click and drag
fix multiple bugs: patternGetValue missing return, clipboard PS quoting, regex group accessor, command binding to prototype vs instance, isolated PS shared buffers, mouseScroll event not enqueued, getDeviceTime signature mismatch; add windows: getWindowElement command; Implement end to end tests with real calculator, notepad and todo apps
- Reject outputPath values that don't end with .mp4, since the hardcoded ffmpeg args (-movflags +faststart, libx264) only produce valid MP4 output - Guard getVideoPath() with fs.stat to ensure the path resolves to a regular file before it can be passed to rimraf, preventing accidental deletion of directories or unrelated files - Add e2e tests: valid outputPath persists on disk after stop, invalid extension is rejected with an explanatory error message
y-schwab
force-pushed
the
feat/unit-testing-commands
branch
from
bf0c1a4 to
8aa49dd
Compare
teo-nikolov
approved these changes
Mar 6, 2026
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Appium?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...