Skip to content

Feat/extra w3c commands#59

Merged
teo-nikolov merged 14 commits intoAutomateThePlanet:mainfrom
y-schwab:feat/extra-w3c-commands
Mar 6, 2026
Merged

Feat/extra w3c commands#59
teo-nikolov merged 14 commits intoAutomateThePlanet:mainfrom
y-schwab:feat/extra-w3c-commands

Conversation

@y-schwab
Copy link
Copy Markdown
Contributor

@y-schwab y-schwab commented Mar 5, 2026

These are extra W3C commands with their own unit and e2e tests. With these commands, NovaWindows would completely support all commands that were supported by WinAppDriver.

This branch is pulled from another one which should be merged before merging this one.

@teo-nikolov teo-nikolov self-requested a review March 6, 2026 12:59
Comment thread lib/commands/extension.ts
Comment thread lib/commands/extension.ts
@teo-nikolov
Copy link
Copy Markdown
Collaborator

There's a minor linting issue failing the CI. Also, if possible, can you update the commit messages as requested in the last PR so the changes can properly be included in the changelog as our CI automatically generates them?

Thank you again for the great contributions to NovaWindows Driver!

fix multiple bugs: patternGetValue missing return, clipboard PS quoting, regex group accessor, command binding to prototype vs instance, isolated PS shared buffers, mouseScroll event not enqueued, getDeviceTime signature mismatch; add windows: getWindowElement command;
Implement end to end tests with real calculator, notepad and todo apps
- Reject outputPath values that don't end with .mp4, since the hardcoded
  ffmpeg args (-movflags +faststart, libx264) only produce valid MP4 output
- Guard getVideoPath() with fs.stat to ensure the path resolves to a
  regular file before it can be passed to rimraf, preventing accidental
  deletion of directories or unrelated files
- Add e2e tests: valid outputPath persists on disk after stop, invalid
  extension is rejected with an explanatory error message
* getTitle, back, forward, setWindowsRect, getElementsScreenshot
@y-schwab y-schwab force-pushed the feat/extra-w3c-commands branch from b3b0fd8 to 57c654a Compare March 6, 2026 18:32
@teo-nikolov teo-nikolov self-requested a review March 6, 2026 22:02
@teo-nikolov teo-nikolov merged commit 30cc867 into AutomateThePlanet:main Mar 6, 2026
1 check passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2026

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@teo-nikolov teo-nikolov linked an issue Mar 9, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

💡 feat: ms:waitForAppLaunch capability

3 participants