Skip to content

Fix/windows 10 scaling#64

Closed
y-schwab wants to merge 2 commits intoAutomateThePlanet:mainfrom
y-schwab:fix/windows-10-scaling
Closed

Fix/windows 10 scaling#64
y-schwab wants to merge 2 commits intoAutomateThePlanet:mainfrom
y-schwab:fix/windows-10-scaling

Conversation

@y-schwab
Copy link
Copy Markdown
Contributor

Proposed changes

This is a simple fix for the scaling problem reported in issue #45
It makes the screenshot command aware of DPS. There's also an added end to end test that checks if the coordinates match.
The problem isn't reproducible in Windows 11 - my machine - so I need the fix to be tested in a Windows 10 machine before merging. Can you do that @teo-nikolov ?

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@y-schwab y-schwab closed this by deleting the head repository Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant