Conversation
- Also added a method for disabling retries for requests, to be used by creation API calls we don't want accidentally duplicated
…nd use our own error dilivery methods
…anges Error handling changes
…rrors-reported-by-checkstyle Fix style errors reported by checkstyle
Feature/40 comment store
The WPCom authenticator was too narrow a scope for this class, as it's used by XML-RPC as well (and also WP-API).
…pected-error Add extra infos to unexpected errors / add url to XMLRPC parse errors
…ding-media Media uploading first fix
Description: "This rule detects and reports usages of magic numbers in the code. Prefer defining constants with clear names describing what the magic number means." For more info see: https://detekt.dev/docs/rules/style/#magicnumber
Description: "Long lines might be hard to read on smaller screens or printouts. Additionally, having a maximum line length in the codebase will help make the code more uniform." For more info see: https://detekt.dev/docs/rules/style/#maxlinelength
Description: "Having many exit points in a function can be confusing and impacts readability of the code." For more info see: https://detekt.dev/docs/rules/style/#returncount
Description: "A class which only contains utility variables and functions with no concrete implementation can be refactored into an 'object' or a class with a non-public constructor. Furthermore, this rule reports utility classes which are not final." For more info see: https://detekt.dev/docs/rules/style/ #utilityclasswithpublicconstructor Note: As part of this commit, the unused 'versionRegex' was also removed from the 'WhatsNewAppVersionUtils' utility class.
…etekt-baseline-warnings [Detekt Baseline Warnings] FluxC Module - Resolve/Suppress Style Warnings
Description: "Exceptions should not be swallowed. This rule reports all instances where exceptions are 'caught' and not correctly passed (e.g. as a cause) into a newly thrown exception. The exception types configured in 'ignoredExceptionTypes' indicate nonexceptional outcomes. These by default configured exception types are part of Java. Therefore, Kotlin developers have to handle them by using the catch clause. For that reason, this rule ignores that these configured exception types are caught." For more info see: https://detekt.dev/docs/rules/exceptions #swallowedexception
Description: "This rule reports catch blocks for exceptions that have a type that is too generic. It should be preferred to catch specific exceptions to the case that is currently handled. If the scope of the caught exception is too broad it can lead to unintended exceptions being caught." For more info see: https://detekt.dev/docs/rules/exceptions #toogenericexceptioncaught
…etekt-baseline-warnings [Detekt Baseline Warnings] FluxC Module - Resolve/Suppress Other Warnings
This connected test was temporarily disabled as it was only failing in CircleCI. However, since CircleCI is not longer being used for this project, and instead, this project is now using Buildkite, this test is being re-enabled.
While 'testQueueForUpload' passes, 'testQueueForUploadForInvalidUuid' fails and thus temporarily ignored.
…e-stack-encrypted-log-test [Test] Re-Enable Release Stack Encrypted Log Connected Test
…rypted-logging-endpoint Fix a crash that occurs when parsing the result of encrypted-logging endpoint
…-message-npe Fixed the VolleyError NPE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces core code of the Encrypted Logging feature, taken from FluxC project. In consist all commits that modified those files, with changes of packages and imports, to align with the new project structure.
I did it using
filter-repotool, with the following command:where
expressions.txtis