Index out of range measuring glyphs#190
Merged
Conversation
TextEmbeddedObject don't have a defined StringRange, so we cannot calculate the glyphWidths for them. The previous implementation used the embedded object size as glyph widths. I modified current implementation to behave in the same way. Implemented the same for Tab TextRun.
- Use the tab width from paragraph properties. - Split runs with mixed tabs and spaces in different runs.
Just return the tab width when measuring it, so I avoid splitting runs, that is much more complex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #189.
Fixed the following issues:
IndexOutOfRangeexception.Demo (using control characters and folding):
fix.mp4
Demo (mixing spaces and tabs now works as expected):
tabs.mp4