updates to loop logic and documentation#14506
Open
AcceleryntSecurityDev wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the Checkmarx SAST ingestion playbook to improve pagination/loop behavior and refresh related documentation so deployments and post-deployment tuning are clearer.
Changes:
- Added ARM parameters for DCE/DCR resource names to avoid same-RG naming collisions.
- Updated Logic App workflow logic (scan/result pagination, batching, token handling) and tuned execution limits/concurrency.
- Updated README deployment links and added a post-deployment tuning section.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Playbooks/AS-Checkmarx-SAST-Ingestion/azuredeploy.json | Adds DCE/DCR name parameters and updates Logic App pagination/loop behavior & role assignment scope. |
| Playbooks/AS-Checkmarx-SAST-Ingestion/README.md | Updates deploy buttons to this repo and documents new deployment/tuning guidance. |
Comment on lines
+120
to
125
| "defaultValue": 2, | ||
| "minValue": 1, | ||
| "metadata": { | ||
| "description": "Number of days prior to each run to pull completed Checkmarx scans from. Set higher for an initial backfill, then lower for steady-state daily runs." | ||
| } | ||
| }, | ||
| "ScanPageSize": { | ||
| "type": "int", | ||
| "defaultValue": 100, | ||
| "metadata": { | ||
| "description": "Page size for the Checkmarx /api/scans pagination loop" | ||
| } | ||
| }, | ||
| "BatchSize": { | ||
| "type": "int", | ||
| "defaultValue": 200, | ||
| "metadata": { | ||
| "description": "Number of SAST results sent per DCR ingestion request. The DCR API enforces a 1 MB maximum payload size; this controls how results are chunked to stay under that limit." | ||
| "description": "Number of days prior to each run to pull completed Checkmarx scans from. Default is 2. Set higher for an initial backfill, then reduce for steady-state daily operation. Can be changed later by editing the LookbackDays variable in the Logic App's Initialize_Variables action." | ||
| } | ||
| } |
Comment on lines
299
to
313
| { | ||
| "name": "BatchSize", | ||
| "name": "ScanPageSize", | ||
| "type": "integer", | ||
| "value": "[parameters('BatchSize')]" | ||
| "value": 100 | ||
| }, | ||
| { | ||
| "name": "ScanPageSize", | ||
| "name": "ResultPageSize", | ||
| "type": "integer", | ||
| "value": 1000 | ||
| }, | ||
| { | ||
| "name": "BatchSize", | ||
| "type": "integer", | ||
| "value": "[parameters('ScanPageSize')]" | ||
| "value": 200 | ||
| }, |
Comment on lines
+788
to
+792
| "runtimeConfiguration": { | ||
| "concurrency": { | ||
| "repetitions": 10 | ||
| } | ||
| } |
| * Role assignment may still be propagating. Wait up to 10 minutes after deployment before retrying. | ||
|
|
||
| **Logic App fails at "HTTP - Get Token" step:** | ||
| **Logic App fails at "HTTP - Get Token Initial" or "HTTP - Refresh Token" step:** |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change(s):
Version Updated:
-N/A
Testing Completed: