Skip to content

Add content safety to smoke test#1975

Merged
qiaozha merged 12 commits intoAzure:mainfrom
qiaozha:add-content-safety-to-smoke-test
Aug 18, 2023
Merged

Add content safety to smoke test#1975
qiaozha merged 12 commits intoAzure:mainfrom
qiaozha:add-content-safety-to-smoke-test

Conversation

@qiaozha
Copy link
Copy Markdown
Member

@qiaozha qiaozha commented Aug 16, 2023

fixes #1974

Copy link
Copy Markdown
Member Author

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin point where the issues are.

Comment thread packages/typespec-test/test/contentsafety_modular/spec/models.tsp
@qiaozha qiaozha marked this pull request as ready for review August 17, 2023 08:36
Copy link
Copy Markdown
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left small comments and could you confirm if the default handling would introduce un-necessary breaking behaviors in future?

Comment thread packages/typespec-ts/src/modular/helpers/operationHelpers.ts Outdated
Comment thread packages/typespec-ts/src/modular/helpers/operationHelpers.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues found in content safety modular

2 participants