Fix unix timestamps#2135
Merged
timovv merged 5 commits intoAzure:mainfrom Nov 21, 2024
Merged
Conversation
microsoft-github-policy-service
Bot
added
the
no-recent-activity
3 tasks
microsoft-github-policy-service
Bot
removed
the
no-recent-activity
timovv
added
no-recent-activity
timovv
requested review from
MaryGao,
joheredi,
qiaozha and
sarangan12
as code owners
maorleger
reviewed
Nov 19, 2024
maorleger
approved these changes
Nov 21, 2024
Member
maorleger
left a comment
maorleger
left a comment
There was a problem hiding this comment.
LGTM. One nit about the bitwise or usage but totally up to you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS timestamps are in milliseconds from the epoch by default whereas standard Unix timestamps are in seconds. This PR changes the code to divide/multiply by 1000 for the conversion