Move to prettier v3#2184
Merged
jeremymeng merged 9 commits intoAzure:mainfrom Jan 9, 2024
Merged
Conversation
as they are used in runtime to format generated code.
b19f05c to
1da5730
Compare
Member
Author
joheredi
approved these changes
Jan 8, 2024
MaryGao
reviewed
Jan 9, 2024
| // Format the contents if necessary | ||
| if (isJson || isSourceCode) { | ||
| fileContents = prettier.format( | ||
| fileContents = await prettier.format( |
Member
There was a problem hiding this comment.
Is this introduced by upgrade?
Member
Author
There was a problem hiding this comment.
yes, v3 makes the method async.
MaryGao
approved these changes
Jan 9, 2024
Member
Author
Prettier v3 has some changes in options' default values, the most impactful one to us is the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev-tool run vendoredprefix for prettier when generating for Azure SDK for JS repo. Dependency on prettier is no longer used thus removed. Related PR: [engsys][core] switch to run prettier from dev-tool's dependency azure-sdk-for-js#28127