Skip to content

upgrade version for test-recorder and test-credential && support RECORDINGS_RELATIVE_PATH in vitest.browser.config.ts#2528

Merged
MaryGao merged 7 commits intoAzure:mainfrom
kazrael2119:upgrade-version-for-esm
Jun 13, 2024
Merged

upgrade version for test-recorder and test-credential && support RECORDINGS_RELATIVE_PATH in vitest.browser.config.ts#2528
MaryGao merged 7 commits intoAzure:mainfrom
kazrael2119:upgrade-version-for-esm

Conversation

@kazrael2119
Copy link
Copy Markdown
Member

@kazrael2119 kazrael2119 commented May 20, 2024

fixes #2524
fixes #2448
fixes #2354

@kazrael2119 kazrael2119 marked this pull request as ready for review May 23, 2024 02:49
@qiaozha qiaozha changed the title upgrade version for esm upgrade version for test recorder May 23, 2024
@kazrael2119 kazrael2119 changed the title upgrade version for test recorder upgrade version for test-recorder and test-credential May 23, 2024
@kazrael2119 kazrael2119 changed the title upgrade version for test-recorder and test-credential upgrade version for test-recorder and test-credential && support RECORDINGS_RELATIVE_PATH in vitest.browser.config.ts May 23, 2024
Copy link
Copy Markdown
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try all these fixes in network.analytis pr in sdk repo?

@MaryGao MaryGao self-requested a review June 13, 2024 08:57
@MaryGao
Copy link
Copy Markdown
Member

MaryGao commented Jun 13, 2024

Could you try all these fixes in network.analytis pr in sdk repo?

verified here: Azure/azure-sdk-for-js#29770

Copy link
Copy Markdown
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryGao MaryGao merged commit 43d8054 into Azure:main Jun 13, 2024
@kazrael2119 kazrael2119 deleted the upgrade-version-for-esm branch June 14, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants