Skip to content

networkanalytics with modular#2536

Merged
qiaozha merged 8 commits intoAzure:mainfrom
kazrael2119:networkanalytics
May 23, 2024
Merged

networkanalytics with modular#2536
qiaozha merged 8 commits intoAzure:mainfrom
kazrael2119:networkanalytics

Conversation

@kazrael2119
Copy link
Copy Markdown
Member

@kazrael2119 kazrael2119 commented May 21, 2024

fixes #2535
fixes #2353

Comment thread packages/typespec-ts/src/modular/buildCodeModel.ts Outdated
Comment thread packages/typespec-ts/src/modular/buildCodeModel.ts Outdated
Comment thread packages/typespec-ts/src/modular/emitModels.ts Outdated
Comment thread packages/typespec-ts/src/modular/emitModels.ts Outdated
Comment thread packages/typespec-ts/src/transform/transfromRLCOptions.ts
@kazrael2119 kazrael2119 marked this pull request as ready for review May 23, 2024 07:31
}

export interface ChatCompletionFunctionParameters
extends Record<string, unknown> {}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should treat unknown as any?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use #2078 to track it.

@qiaozha qiaozha merged commit bca289d into Azure:main May 23, 2024
@kazrael2119 kazrael2119 deleted the networkanalytics branch May 23, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should generate as interface not record for empty named model with additional properties user_impersonation is set as default credential scope in RLC

3 participants