Skip to content

treat-unknown-as-any-in-modular#2546

Merged
qiaozha merged 6 commits intoAzure:mainfrom
qiaozha:treat-unknown-as-any-in-modular
May 27, 2024
Merged

treat-unknown-as-any-in-modular#2546
qiaozha merged 6 commits intoAzure:mainfrom
qiaozha:treat-unknown-as-any-in-modular

Conversation

@qiaozha
Copy link
Copy Markdown
Member

@qiaozha qiaozha commented May 23, 2024

fixes #2078

@qiaozha qiaozha marked this pull request as ready for review May 24, 2024 06:51
Copy link
Copy Markdown
Member

@lirenhe lirenhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As this would introduce public API change, please ensure we also get signoff from Redmond team.

Copy link
Copy Markdown
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiaozha
Copy link
Copy Markdown
Member Author

qiaozha commented May 27, 2024

Offline confirmed with @joheredi, this looks good to go :)

@qiaozha qiaozha merged commit 778140a into Azure:main May 27, 2024
@qiaozha qiaozha deleted the treat-unknown-as-any-in-modular branch May 27, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discuss how TypeSpec unknown is generated in DPG

4 participants