Fix some issues with API version handling in new getClient

[timovv]

A couple of bug fixes as a follow up to #2728:

• For API version endpoint parameters, if TCGC does not provide a default API version (e.g. due to TypeSpec versioning not being used), respect the default value provided in the @server decorator, like we do for other params. This fixes the "parametrizedHost" smoke test's apiVersion param not having a default value set.
• Destructure the options to remove the apiVersion option when it is present before passing the options to getClient. This prevents the Core policy from picking it up.

[qiaozha]

If the purpose of the following change

- const updatedOptions = {
+ const { apiVersion: _, ...updatedOptions } = {

is just remove apiVersion from the option, we should always do that, otherwise, for cases like this one apiVersion is required parameter

autorest.typescript/packages/typespec-ts/test/modularUnit/apiOperations.spec.ts

Line 551 in bfaa8fd

const updatedOptions = {

or even we don't have apiVersion in the options, it will get assigned to updatedOptions and passed into core-client-rest

[timovv]

If apiVersion is a required parameter or not present in the options, why would the user ever pass apiVersion in a way that requires it to be removed? If they do, should we really be handling that?

[joheredi]

I think the changes look good. I don't think there are problems when apiVersion is required. If user ends up passing it also in the options, it is good they get the warning from core.

[qiaozha]

I think the changes look good. I don't think there are problems when apiVersion is required. If user ends up passing it also in the options, it is good they get the warning from core.

We will only get warning from core after Azure/azure-sdk-for-js#29904 is merged and we bump the core version, otherwise the current logic will just append a api-version query parameter as the ApiVersionPolicy is in core no matter if the client side has an api version or not. But, in order to get Azure/azure-sdk-for-js#29904 merged, we need codegen to be correctly and explicitly not pass the api version to core if it's not supported and refresh all the existing RLCs as suggested by Azure/azure-sdk-for-js#29883 (comment) step 3, the order is tricky, but I feel like we have to remove it until @xirzec 's PR get merged 😞

[timovv]

Updated to always destructure the API version, regardless of whether the apiVersion parameter is required, optional, or present at all