Skip to content

Remove core-paging dependency in RLC#2785

Merged
MaryGao merged 11 commits intoAzure:mainfrom
kazrael2119:remove-core-paging-dep
Sep 18, 2024
Merged

Remove core-paging dependency in RLC#2785
MaryGao merged 11 commits intoAzure:mainfrom
kazrael2119:remove-core-paging-dep

Conversation

@kazrael2119
Copy link
Copy Markdown
Member

@kazrael2119 kazrael2119 commented Aug 30, 2024

fixes #2780

  • remove core-paging depedency in RLC
  • remove the maxPageSize option in RLC
  • remove the Pagedinterface and directly generate paged model type from definition

Comment thread packages/rlc-common/src/metadata/buildPackageFile.ts
Comment thread packages/rlc-common/src/metadata/packageJson/azurePackageCommon.ts

// @public
export type SupportedLanguagesOutput = Paged<SupportedLanguageOutput>;
export interface SupportedLanguagesOutput {
Copy link
Copy Markdown
Member

@MaryGao MaryGao Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joheredi @qiaozha I prefer to remove the Paged interface and directly generate paged model type as TypeSpec defined. Let me know if you have any concern!

The main reason is it would be better aligned with generating with TypeSpec defined, considering Paged interface would limit the model to have two properties(value & nextLink) so service team want to have additional properties returned or some other strucuture with paging models, this would be impossible to include them and you could see an example here. Also in TS side, we would produce more direct and simpler interface without Paged interface.

Pls note in Modular this model is generated as internal model and it is also without Paged referred. Also I believe this is not a breaking for RLC because the model shape is the same.

@MaryGao MaryGao marked this pull request as ready for review September 18, 2024 04:59
@MaryGao MaryGao changed the title remove core-paging dependency in RLC Remove core-paging dependency in RLC without breakings Sep 18, 2024
@MaryGao MaryGao changed the title Remove core-paging dependency in RLC without breakings Remove core-paging dependency in RLC Sep 18, 2024
@MaryGao MaryGao merged commit 472e895 into Azure:main Sep 18, 2024
@kazrael2119 kazrael2119 deleted the remove-core-paging-dep branch September 19, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove core-paging dependency in RLC

3 participants