Skip to content

[engsys] Use dev-tool command in tshy for monorepo#2843

Merged
maorleger merged 3 commits intoAzure:mainfrom
maorleger:build-package-dev-command
Sep 26, 2024
Merged

[engsys] Use dev-tool command in tshy for monorepo#2843
maorleger merged 3 commits intoAzure:mainfrom
maorleger:build-package-dev-command

Conversation

@maorleger
Copy link
Copy Markdown
Member

@maorleger maorleger commented Sep 25, 2024

Resolves Azure/azure-sdk-for-js#31211

This PR updates the codegen for ESM packages within the monorepo to use the build-package command instead of using tshy directly.

The changes have been made in the azure-sdk-for-js repo, this PR ensures codegen behaves.

callout

this is my first PR in the autorest.typescript repo so please do assume I forgot / missed something and let me know what was missed. I was surprised that smoke tests did not fail, but maybe there's a different command to run them

@maorleger maorleger marked this pull request as ready for review September 25, 2024 21:36
@maorleger
Copy link
Copy Markdown
Member Author

@timovv
Copy link
Copy Markdown
Member

timovv commented Sep 25, 2024

I think the lack of changes to the smoke tests is because we don't overwrite the package.json if it's already present, we just make updates to certain parts of it. It would be good to keep the test baselines up to date though. You should be able to get the smoke tests up to date by going into the typespec-test package and running rush build -t . && rushx smoke-test

@maorleger maorleger merged commit 3de7011 into Azure:main Sep 26, 2024
@maorleger maorleger deleted the build-package-dev-command branch September 26, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use build-package in codegen and the migration command

2 participants