[engsys] Use dev-tool command in tshy for monorepo#2843
Merged
maorleger merged 3 commits intoAzure:mainfrom Sep 26, 2024
Merged
[engsys] Use dev-tool command in tshy for monorepo#2843maorleger merged 3 commits intoAzure:mainfrom
maorleger merged 3 commits intoAzure:mainfrom
Conversation
Member
Author
Member
|
I think the lack of changes to the smoke tests is because we don't overwrite the |
timovv
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Azure/azure-sdk-for-js#31211
This PR updates the codegen for ESM packages within the monorepo to use the
build-packagecommand instead of using tshy directly.The changes have been made in the azure-sdk-for-js repo, this PR ensures codegen behaves.
callout
this is my first PR in the autorest.typescript repo so please do assume I forgot / missed something and let me know what was missed. I was surprised that smoke tests did not fail, but maybe there's a different command to run them