Skip to content

update azureSdkForJs default value when flavor !== azure #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiaozha merged 5 commits into from
Nov 22, 2024
Merged

update azureSdkForJs default value when flavor !== azure #2921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73142ae
update azureSdkForJs default value when flavor !== azure
kazrael2119 Nov 21, 2024
481fd3f
format
kazrael2119 Nov 21, 2024
7dbaddf
revert
kazrael2119 Nov 21, 2024
b61ee35
update
kazrael2119 Nov 22, 2024
d2fe66a
Merge branch 'main' into update-default-value
qiaozha Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/typespec-test/test/openai_generic/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ emit:
- "@azure-tools/typespec-ts"
options:
"@azure-tools/typespec-ts":
azureSdkForJs: false
isModularLibrary: true
"emitter-output-dir": "{project-root}/generated/typespec-ts"
ignorePropertyNameNormalize: true
Expand Down
1 change: 0 additions & 1 deletion packages/typespec-test/test/openai_non_branded/spec/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ options:
"@azure-tools/typespec-ts":
isModularLibrary: true
generateMetadata: true
azureSdkForJs: false
branded: false
"emitter-output-dir": "{project-root}/../generated/typespec-ts"
packageDetails:
Expand Down
10 changes: 6 additions & 4 deletions packages/typespec-ts/src/transform/transfromRLCOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,12 @@ function getServiceInfo(program: Program): ServiceInfo {
}

function getAzureSdkForJs(emitterOptions: EmitterOptions) {
return emitterOptions.azureSdkForJs === undefined ||
emitterOptions.azureSdkForJs === null
? true
: Boolean(emitterOptions.azureSdkForJs);
return emitterOptions.flavor !== "azure"
? false
: emitterOptions.azureSdkForJs === undefined ||
emitterOptions.azureSdkForJs === null
? true
: Boolean(emitterOptions.azureSdkForJs);
}

function getGenerateMetadata(emitterOptions: EmitterOptions) {
Expand Down
⚡