Skip to content

model namespaces hierarchies#2969

Merged
qiaozha merged 11 commits intoAzure:mainfrom
qiaozha:respect-model-namespaces-as-hierarchies
Jan 14, 2025
Merged

model namespaces hierarchies#2969
qiaozha merged 11 commits intoAzure:mainfrom
qiaozha:respect-model-namespaces-as-hierarchies

Conversation

@qiaozha
Copy link
Copy Markdown
Member

@qiaozha qiaozha commented Dec 30, 2024

fixes #2757

@qiaozha
Copy link
Copy Markdown
Member Author

qiaozha commented Dec 31, 2024

need to revisit the subpath user experience for ARM, data-plane, non branded.

@qiaozha qiaozha changed the title respect-model-namespaces-as-hierarchies model namespaces hierarchies Jan 2, 2025
@qiaozha
Copy link
Copy Markdown
Member Author

qiaozha commented Jan 6, 2025

need to revisit the subpath user experience for ARM, data-plane, non branded.

we can provide an option to decide if we want to export multi-level models subpath, for azure scope, it should default to false, for unbranded scope it should default to true.

Comment thread packages/typespec-ts/src/index.ts
Comment thread packages/typespec-test/test/ai/generated/typespec-ts/src/models/index.ts Outdated
@qiaozha qiaozha marked this pull request as ready for review January 13, 2025 08:14
Copy link
Copy Markdown
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As offline discussed, we could restrict sub-path models to follow the namespace convention then we could have consistant behavior with api layer.

Comment thread packages/typespec-ts/src/modular/buildHelperSerializers.ts
Comment thread packages/typespec-ts/src/modular/buildHelperSerializers.ts
@qiaozha qiaozha merged commit 5854c92 into Azure:main Jan 14, 2025
@qiaozha qiaozha deleted the respect-model-namespaces-as-hierarchies branch January 14, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate TypeScript codes with hierarchical folders as namespace

2 participants