Support snippets for Modular/RLC/HLC#3052
Merged
MaryGao merged 25 commits intoAzure:mainfrom Feb 19, 2025
Merged
Conversation
MaryGao
reviewed
Feb 13, 2025
MaryGao
reviewed
Feb 18, 2025
MaryGao
reviewed
Feb 18, 2025
MaryGao
approved these changes
Feb 18, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 244 out of 255 changed files in this pull request and generated 1 comment.
Files not reviewed (11)
- packages/autorest.typescript/src/generators/static/hlcREADME.md.hbs: Language not supported
- packages/autorest.typescript/src/generators/test/snippets.ts.hbs: Language not supported
- packages/autorest.typescript/src/restLevelClient/generateRestLevel.ts: Evaluated as low risk
- packages/rlc-common/src/index.ts: Evaluated as low risk
- packages/autorest.typescript/src/typescriptGenerator.ts: Evaluated as low risk
- packages/autorest.typescript/test/unit/restLevelClient/files/case-rlcReadme.md: Evaluated as low risk
- packages/autorest.typescript/src/generators/static/readmeFileGenerator.ts: Evaluated as low risk
- packages/autorest.typescript/src/generators/static/packageFileGenerator.ts: Evaluated as low risk
- packages/typespec-ts/src/index.ts: Evaluated as low risk
- packages/rlc-common/src/metadata/packageJson/buildAzureMonorepoPackage.ts: Evaluated as low risk
- packages/autorest.typescript/test/unit/generators/static/files/case-hlcReadme.md: Evaluated as low risk
Comments suppressed due to low confidence (2)
packages/autorest.typescript/src/generators/test/snippetsGenerator.ts:26
- The function hasClientSubscriptionId uses toLocaleLowerCase() which should be toLowerCase().
hasClientSubscriptionId: hasClientSubscriptionId(clientDetails?.samples)
packages/autorest.typescript/test/unit/generators/static/files/case-hlcReadme-without-subid.md:50
- [nitpick] The use of
tsinstead oftypescriptin the code block language identifier might be inconsistent with the rest of the documentation. Consider usingtypescriptfor consistency.
Using Node.js and Node-like environments, you can use the `DefaultAzureCredential` class to authenticate the client.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot reviewed 244 out of 255 changed files in this pull request and generated no comments.
Files not reviewed (11)
- packages/autorest.typescript/src/generators/static/hlcREADME.md.hbs: Language not supported
- packages/autorest.typescript/src/generators/test/snippets.ts.hbs: Language not supported
- packages/autorest.typescript/src/restLevelClient/generateRestLevel.ts: Evaluated as low risk
- packages/rlc-common/src/index.ts: Evaluated as low risk
- packages/autorest.typescript/test/unit/restLevelClient/files/case-rlcReadme.md: Evaluated as low risk
- packages/autorest.typescript/src/typescriptGenerator.ts: Evaluated as low risk
- packages/autorest.typescript/src/generators/static/packageFileGenerator.ts: Evaluated as low risk
- packages/autorest.typescript/src/generators/static/readmeFileGenerator.ts: Evaluated as low risk
- packages/typespec-ts/src/index.ts: Evaluated as low risk
- packages/rlc-common/src/metadata/packageJson/buildAzureMonorepoPackage.ts: Evaluated as low risk
- packages/autorest.typescript/test/unit/generators/static/files/case-hlcReadme.md: Evaluated as low risk
Comments suppressed due to low confidence (2)
packages/rlc-common/src/test/buildSnippets.ts:13
- [nitpick] The variable name azureSdkForJsInfo is ambiguous. It should be renamed to isAzureSdkForJs.
const azureSdkForJsInfo = azureSdkForJs ? azureSdkForJs : model.options?.azureSdkForJs;
packages/rlc-common/src/test/buildSnippets.ts:8
- The new behavior introduced in the buildSnippets function is not covered by tests. Ensure that there are tests to cover this new functionality.
export function buildSnippets(
MaryGao
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3024
fixes #3051
fixes #3025