Skip to content

update smoke test specs to remove deprecated typespec usage #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiaozha merged 4 commits into from
Mar 12, 2025
Merged

update smoke test specs to remove deprecated typespec usage #3103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40dd065
update smoke test tsp
v-jiaodi Mar 11, 2025
68f374f
format
v-jiaodi Mar 11, 2025
95af7a9
regen smoke
v-jiaodi Mar 11, 2025
4522202
update tsp and regen
v-jiaodi Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 40 additions & 40 deletions packages/typespec-test/test/NetworkAnalytics.Management/spec/main.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ using Autorest;
using OpenAPI;

@armProviderNamespace
@service({
@service(#{
title: "Microsoft.NetworkAnalytics",
})
@versioned(Microsoft.NetworkAnalytics.Versions)
Expand Down Expand Up @@ -130,7 +130,7 @@ model DataProductNetworkAcls {
virtualNetworkRule: VirtualNetworkRule[];

@doc("IP rule with specific IP or IP range in CIDR format.")
@extension("x-ms-identifiers", [])
@extension("x-ms-identifiers", #[])
ipRules: IPRules[];

@doc("The list of query ips in the format of CIDR allowed to connect to query/visualization endpoint.")
Expand Down Expand Up @@ -159,83 +159,83 @@ model DataProduct is TrackedResource<DataProductProperties> {
@added(Versions.v2023_11_15)
model DataProductProperties {
@doc("The resource GUID property of the data product resource.")
@visibility("read")
@visibility(Lifecycle.Read)
resourceGuid?: string;

@doc("Latest provisioning state of data product.")
@visibility("read")
@visibility(Lifecycle.Read)
provisioningState?: ProvisioningState;

@doc("Data product publisher name.")
@visibility("create", "read")
@visibility(Lifecycle.Create, Lifecycle.Read)
publisher: string;

@doc("Product name of data product.")
@visibility("create", "read")
@visibility(Lifecycle.Create, Lifecycle.Read)
product: string;

@doc("Major version of data product.")
@visibility("create", "read")
@visibility(Lifecycle.Create, Lifecycle.Read)
majorVersion: string;

@doc("List of name or email associated with data product resource deployment.")
@visibility("create", "read", "update")
@visibility(Lifecycle.Create, Lifecycle.Read, Lifecycle.Update)
owners?: string[];

@doc("Flag to enable or disable redundancy for data product.")
@visibility("create", "read")
@visibility(Lifecycle.Create, Lifecycle.Read)
redundancy?: ControlState;

@doc("Purview account url for data product to connect to.")
@visibility("create", "update", "read")
@visibility(Lifecycle.Create, Lifecycle.Update, Lifecycle.Read)
purviewAccount?: string;

@doc("Purview collection url for data product to connect to.")
@visibility("create", "update", "read")
@visibility(Lifecycle.Create, Lifecycle.Update, Lifecycle.Read)
purviewCollection?: string;

@doc("Flag to enable or disable private link for data product resource.")
@visibility("create", "update", "read")
@visibility(Lifecycle.Create, Lifecycle.Update, Lifecycle.Read)
privateLinksEnabled?: ControlState;

@doc("Flag to enable or disable public access of data product resource.")
@visibility("create", "read")
@visibility(Lifecycle.Create, Lifecycle.Read)
publicNetworkAccess?: ControlState;

@doc("Flag to enable customer managed key encryption for data product.")
@visibility("create", "read")
@visibility(Lifecycle.Create, Lifecycle.Read)
customerManagedKeyEncryptionEnabled?: ControlState;

@doc("Customer managed encryption key details for data product.")
@visibility("create", "read")
@visibility(Lifecycle.Create, Lifecycle.Read)
customerEncryptionKey?: EncryptionKeyDetails;

@doc("Network rule set for data product.")
@visibility("create", "read")
@visibility(Lifecycle.Create, Lifecycle.Read)
networkacls?: DataProductNetworkAcls;

@doc("Managed resource group configuration.")
@visibility("create")
@visibility(Lifecycle.Create)
managedResourceGroupConfiguration?: ManagedResourceGroupConfiguration;

@doc("List of available minor versions of the data product resource.")
@visibility("read")
@visibility(Lifecycle.Read)
availableMinorVersions?: string[];

@doc("Current configured minor version of the data product resource.")
@visibility("read", "update")
@visibility(Lifecycle.Read, Lifecycle.Update)
currentMinorVersion?: string;

@doc("Documentation link for the data product based on definition file.")
@visibility("read")
@visibility(Lifecycle.Read)
documentation?: string;

@doc("Resource links which exposed to the customer to query the data.")
@visibility("read")
@visibility(Lifecycle.Read)
consumptionEndpoints?: ConsumptionEndpointsProperties;

@doc("Key vault url.")
@visibility("read")
@visibility(Lifecycle.Read)
keyVaultUrl?: string;
}

Expand Down Expand Up @@ -268,35 +268,35 @@ union ControlState {
@added(Versions.v2023_11_15)
model ConsumptionEndpointsProperties {
@doc("Ingestion url to upload the data.")
@visibility("read")
@visibility(Lifecycle.Read)
ingestionUrl?: string;

@doc("Resource Id of ingestion endpoint.")
@visibility("read")
@visibility(Lifecycle.Read)
ingestionResourceId?: Azure.Core.armResourceIdentifier<[
{
type: "Microsoft.Storage/storageAccounts";
}
]>;

@doc("Url to consume file type.")
@visibility("read")
@visibility(Lifecycle.Read)
fileAccessUrl?: string;

@doc("Resource Id of file access endpoint.")
@visibility("read")
@visibility(Lifecycle.Read)
fileAccessResourceId?: Azure.Core.armResourceIdentifier<[
{
type: "Microsoft.Storage/storageAccounts";
}
]>;

@doc("Url to consume the processed data.")
@visibility("read")
@visibility(Lifecycle.Read)
queryUrl?: string;

@doc("Resource Id of query endpoint.")
@visibility("read")
@visibility(Lifecycle.Read)
queryResourceId?: Azure.Core.armResourceIdentifier<[
{
type: "Microsoft.Kusto/clusters";
Expand Down Expand Up @@ -358,31 +358,31 @@ model DataType is ProxyResource<DataTypeProperties> {
@added(Versions.v2023_11_15)
model DataTypeProperties {
@doc("Latest provisioning state of data product.")
@visibility("read")
@visibility(Lifecycle.Read)
provisioningState?: ProvisioningState;

@doc("State of data type.")
@visibility("read", "create", "update")
@visibility(Lifecycle.Read, Lifecycle.Create, Lifecycle.Update)
state?: DataTypeState;

@doc("Reason for the state of data type.")
@visibility("read")
@visibility(Lifecycle.Read)
stateReason?: string;

@doc("Field for storage output retention in days.")
@visibility("read", "create", "update")
@visibility(Lifecycle.Read, Lifecycle.Create, Lifecycle.Update)
storageOutputRetention?: int32;

@doc("Field for database cache retention in days.")
@visibility("read", "create", "update")
@visibility(Lifecycle.Read, Lifecycle.Create, Lifecycle.Update)
databaseCacheRetention?: int32;

@doc("Field for database data retention in days.")
@visibility("read", "create", "update")
@visibility(Lifecycle.Read, Lifecycle.Create, Lifecycle.Update)
databaseRetention?: int32;

@doc("Url for data visualization.")
@visibility("read")
@visibility(Lifecycle.Read)
visualizationUrl?: string;
}

Expand Down Expand Up @@ -416,7 +416,7 @@ model ListRoleAssignments {
count: int32;

@doc("list of role assignments")
@extension("x-ms-identifiers", ["roleAssignmentId"])
@extension("x-ms-identifiers", #["roleAssignmentId"])
roleAssignmentResponse: RoleAssignmentDetail[];
}

Expand Down Expand Up @@ -473,11 +473,11 @@ model DataProductsCatalog is ProxyResource<DataProductsCatalogProperties> {
@added(Versions.v2023_11_15)
model DataProductsCatalogProperties {
@doc("The data catalog provisioning state.")
@visibility("read")
@visibility(Lifecycle.Read)
provisioningState?: ProvisioningState;

@doc("The data product publisher information.")
@extension("x-ms-identifiers", [])
@extension("x-ms-identifiers", #[])
publishers: PublisherInformation[];
}

Expand All @@ -488,7 +488,7 @@ model PublisherInformation {
publisherName: string;

@doc("Data product information.")
@extension("x-ms-identifiers", [])
@extension("x-ms-identifiers", #[])
dataProducts: DataProductInformation[];
}

Expand All @@ -502,7 +502,7 @@ model DataProductInformation {
description: string;

@doc("Version information of data product.")
@extension("x-ms-identifiers", [])
@extension("x-ms-identifiers", #[])
dataProductVersions: DataProductVersion[];
}

Expand Down
42 changes: 21 additions & 21 deletions packages/typespec-test/test/ai/spec/evaluations/model.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,19 @@ namespace Azure.AI.Projects;

@doc("Metadata pertaining to creation and last modification of the resource.")
model SystemData {
@visibility("read")
@visibility(Lifecycle.Read)
@doc("The timestamp the resource was created at.")
createdAt?: utcDateTime;

@visibility("read")
@visibility(Lifecycle.Read)
@doc("The identity that created the resource.")
createdBy?: string;

@visibility("read")
@visibility(Lifecycle.Read)
@doc("The identity type that created the resource.")
createdByType?: string;

@visibility("read")
@visibility(Lifecycle.Read)
@doc("The timestamp of resource last modification (UTC)")
lastModifiedAt?: utcDateTime;
}
Expand Down Expand Up @@ -56,7 +56,7 @@ model InputData {

@doc("Data Source for Application Insights.")
model ApplicationInsightsConfiguration extends InputData {
@visibility("read")
@visibility(Lifecycle.Read)
type: "app_insights";

@doc("LogAnalytic Workspace resourceID associated with ApplicationInsights")
Expand All @@ -74,7 +74,7 @@ model ApplicationInsightsConfiguration extends InputData {

@doc("Dataset as source for evaluation.")
model Dataset extends InputData {
@visibility("read")
@visibility(Lifecycle.Read)
type: "dataset";

@doc("Evaluation input data")
Expand All @@ -92,7 +92,7 @@ model Trigger {
#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Needed since suggestion is not supported to generate swagger in OpenAPIv2"
@doc("Recurrence Trigger Definition")
model RecurrenceTrigger extends Trigger {
@visibility("read")
@visibility(Lifecycle.Read)
type: "Recurrence";

@doc("The frequency to trigger schedule.")
Expand All @@ -108,7 +108,7 @@ model RecurrenceTrigger extends Trigger {
#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Needed since suggestion is not supported to generate swagger in OpenAPIv2"
@doc("Cron Trigger Definition")
model CronTrigger extends Trigger {
@visibility("read")
@visibility(Lifecycle.Read)
type: "Cron";

@doc("Cron expression for the trigger.")
Expand All @@ -119,14 +119,14 @@ model CronTrigger extends Trigger {
@resource("runs")
model Evaluation {
@key("id")
@visibility("read")
@visibility(Lifecycle.Read)
@doc("Identifier of the evaluation.")
@pattern("^[a-zA-Z0-9][a-zA-Z0-9-_]*$")
@maxLength(254)
id: string;

@doc("Data for evaluation.")
@visibility("read", "create")
@visibility(Lifecycle.Read, Lifecycle.Create)
data: InputData;

@doc("Display Name for evaluation. It helps to find the evaluation easily in AI Foundry. It does not need to be unique.")
Expand All @@ -136,22 +136,22 @@ model Evaluation {
description?: string;

@doc("Metadata containing createdBy and modifiedBy information.")
@visibility("read")
@visibility(Lifecycle.Read)
systemData?: SystemData;

@doc("Status of the evaluation. It is set by service and is read-only.")
@visibility("read")
@visibility(Lifecycle.Read)
status?: string;

@doc("Evaluation's tags. Unlike properties, tags are fully mutable.")
tags?: Record<string>;

@doc("Evaluation's properties. Unlike tags, properties are add-only. Once added, a property cannot be removed.")
@visibility("read", "create")
@visibility(Lifecycle.Read, Lifecycle.Create)
properties?: Record<string>;

@doc("Evaluators to be used for the evaluation.")
@visibility("read", "create")
@visibility(Lifecycle.Read, Lifecycle.Create)
evaluators: Record<EvaluatorConfiguration>;
}

Expand Down Expand Up @@ -199,40 +199,40 @@ model RecurrenceSchedule {
@resource("schedules")
model EvaluationSchedule {
@key("name")
@visibility("read")
@visibility(Lifecycle.Read)
@doc("Name of the schedule, which also serves as the unique identifier for the evaluation")
@pattern("^[a-zA-Z0-9][a-zA-Z0-9-_]*$")
@maxLength(254)
name: string;

@doc("Data for evaluation.")
@visibility("read", "create")
@visibility(Lifecycle.Read, Lifecycle.Create)
data: ApplicationInsightsConfiguration;

@doc("Description of the evaluation. It can be used to store additional information about the evaluation and is mutable.")
description?: string;

@doc("Metadata containing createdBy and modifiedBy information.")
@visibility("read")
@visibility(Lifecycle.Read)
systemData?: SystemData;

@doc("Provisioning State of the evaluation. It is set by service and is read-only.")
@visibility("read")
@visibility(Lifecycle.Read)
provisioningState?: string;

@doc("Evaluation's tags. Unlike properties, tags are fully mutable.")
tags?: Record<string>;

@doc("Evaluation's properties. Unlike tags, properties are add-only. Once added, a property cannot be removed.")
@visibility("read", "create")
@visibility(Lifecycle.Read, Lifecycle.Create)
properties?: Record<string>;

@doc("Enabled status of the evaluation. It is set by service and is read-only.")
@visibility("read")
@visibility(Lifecycle.Read)
isEnabled?: string;

@doc("Evaluators to be used for the evaluation.")
@visibility("read", "create")
@visibility(Lifecycle.Read, Lifecycle.Create)
evaluators: Record<EvaluatorConfiguration>;

@doc("Trigger for the evaluation.")
Expand Down
Loading
⚡